Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Write browser tests for the APM Create/Edit Integration Settings #123399

Closed
ogupte opened this issue Jan 19, 2022 · 2 comments · Fixed by #129860
Closed

[APM] Write browser tests for the APM Create/Edit Integration Settings #123399

ogupte opened this issue Jan 19, 2022 · 2 comments · Fixed by #129860
Assignees
Labels
apm:fleet apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture test-coverage issues & PRs for improving code test coverage

Comments

@ogupte
Copy link
Contributor

ogupte commented Jan 19, 2022

It's important to write and maintain browser tests related to the the APM integration UI since it's a point of integration between Fleet and APM, it should be checked when either plugin has changes. See the existing [Fleet cypress tests] (https://github.com/elastic/kibana/blob/157a37114fba5b1e88c018492e733ed66c29b231/x-pack/test/fleet_cypress/fleet_server.ts) as an example of how to have the Fleet Server set up and enrolled in order to load the policy editor.

Policy Form

when navigating to the integration page
  - [ ] the Elastic APM in Fleet tab is available
  - [ ] the Manage APM integration in Fleet button is available
 
    and clicking on the button
       - [ ] it redirects to the integration policies
       - [ ] if package <= 8.00 tail based is not available
       - [ ] it creates an integration policy 

 when navigating to the integrations policy
   - [ ] it edits the existing integration policy
   - [ ] it deletes the existing integration policy

 when navigating to the integrations policy with installed package >= 8.1.0
   - [ ] it shows tail-based sampling configuration
@ogupte ogupte added [zube]: Inbox apm:fleet Team:APM All issues that need APM UI Team support labels Jan 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dannycroft dannycroft added test-v7.3.0 test-coverage issues & PRs for improving code test coverage technical debt Improvement of the software architecture and operational architecture and removed [zube]: Inbox labels Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:fleet apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture test-coverage issues & PRs for improving code test coverage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants