Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gauge] Use EC library instead of the vislib one #124925

Closed
14 of 17 tasks
Kuznietsov opened this issue Feb 8, 2022 · 4 comments
Closed
14 of 17 tasks

[Gauge] Use EC library instead of the vislib one #124925

Kuznietsov opened this issue Feb 8, 2022 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Gauge Vis Gauge and goal visualization impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. NeededFor:VisEditors Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@Kuznietsov
Copy link
Contributor

Kuznietsov commented Feb 8, 2022

Introduction

In order to the issue, it is required to add support of some features, absent at the gauge visualization from expression_charts, but used at vislib's gauge. Some of these features are blocked on the side of elastic-charts and will be addressed separately. The others will be encountered at this issue and addressed at the follow-up PRs.

Required features:

  • Add support of arc/circle shapes.
  • Add support of the show/hide scale functionality. (Add hide option to the ticksPosition argument)
  • Add support of visdimensions at *Accessor args.
  • For the purpose of the consistency, change metricAccessor, minAccessor, maxAccessor, goalAccessor to metric, max, min, goal. Don't have a strong opinion about it, but it seems to me very logical. @stratoula, @flash1293, WDYT?

Updates:

  • Add transparent background
  • Add percentage mode for support of legacy behavior
  • Move current implementation of band colors to getColorForValue from custom palette (it supports continuity).
  • Add logDatatable functionality to the gauge expression function.
  • Support of overriding colors.

After delivering required features by elastic-charts

should be added:

  • Outlines
  • Small multiples
  • Alignment
@Kuznietsov Kuznietsov added loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure NeededFor:VisEditors labels Feb 8, 2022
@Kuznietsov Kuznietsov self-assigned this Feb 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@Kuznietsov Kuznietsov added the enhancement New value added to drive a business result label Feb 8, 2022
@Kuznietsov
Copy link
Contributor Author

cc @crob611

@flash1293
Copy link
Contributor

Sounds all good to me 👍

@Kuznietsov Kuznietsov removed the loe:small Small Level of Effort label Feb 18, 2022
@Kuznietsov Kuznietsov removed their assignment Jan 4, 2023
@stratoula stratoula added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Jan 13, 2023
@stratoula stratoula changed the title [Gauge] Adapt for VisEditors. [Gauge] Use EC library instead of the vislib one Jan 13, 2023
@stratoula stratoula added the Feature:Gauge Vis Gauge and goal visualization label Jun 1, 2023
@stratoula
Copy link
Contributor

All set!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Gauge Vis Gauge and goal visualization impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. NeededFor:VisEditors Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants