Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gauge] Custom color support #126882

Merged
merged 56 commits into from
Mar 9, 2022
Merged

[Gauge] Custom color support #126882

merged 56 commits into from
Mar 9, 2022

Conversation

Kuznietsov
Copy link
Contributor

@Kuznietsov Kuznietsov commented Mar 4, 2022 •
edited
Loading

Summary

Completes part of #124925.
Added support of the custom colors, assigned at the legacy vislib chart.

Default

Legacy chart

Screenshot 2022-03-08 at 13 11 58

New chart

Screenshot 2022-03-08 at 13 12 46

Percentage mode

Legacy chart

Screenshot 2022-03-08 at 13 15 11

New chart

Screenshot 2022-03-08 at 13 15 38

Kuznietsov and others added 30 commits February 18, 2022 09:38
@Kuznietsov
Added transparent background
064e917
@Kuznietsov
Added gauge/goal visType.
adb0404
@Kuznietsov
Merge branch 'main' into vis_editors_gauge-integration
e21f21a
@Kuznietsov
Fixed palette, scale and types.
6a8c677
@kibanamachine
Merge branch 'main' into vis_editors_gauge-integration
6f309f0
@Kuznietsov
updated tests
7afcbc6
@Kuznietsov
Cleaned up the code.
247689f
@Kuznietsov
Updated limits.
29e9835
@Kuznietsov
Set legacy chart as default.
eae8f8a
@Kuznietsov
Removed deprecation message.
e0200bc
@Kuznietsov
Added percent format params, comming from visdimensions.
b370834
@kibanamachine
Merge branch 'main' into gauge-transparent-background
2b8bbe8
@Kuznietsov
Updated snapshot.
ff70db1
@Kuznietsov
Merge branch 'gauge-transparent-background' of github.com:Kunzetsov/k…
a2f442c 
…ibana into gauge-transparent-background
@Kuznietsov
Merge branch 'gauge-transparent-background' into vis_editors_gauge-in…
6b07be8 
…tegration
@Kuznietsov
Added support of labels/sublabels.
c2e8bab
@kibanamachine
Merge branch 'main' into vis_editors_gauge-integration
48bbd6b
@kibanamachine
Merge branch 'main' into vis_editors_gauge-integration
10d9440
@Kuznietsov
fixed vistype toast test.
573a5fe
@Kuznietsov
fixed i18n.
3d96912
@Kuznietsov
Updated i18n label.
d5d70b9
@kibanamachine
Merge branch 'main' into vis_editors_gauge-integration
2e1717f
@Kuznietsov
Added support of showElasticChartsOptions
9d5c1e4
@Kuznietsov
Added autoextend ranges elastic charts tooltip.
d5d50b9
@Kuznietsov
The outline elastic-charts message added.
2b28506
@Kuznietsov
outline renaming and metric/buckets limitations
4b00e2c
@kibanamachine
Merge branch 'main' into vis_editors_gauge-integration
b601cbc
@Kuznietsov
Added legacy percentage mode to the gauge.
08c2a54
@kibanamachine
Merge branch 'main' into vis_editors_gauge-integration
127b03e
@kibanamachine
Merge branch 'main' into vis_editors_gauge-integration
b1f15c4
@Kuznietsov
Merge branch 'vis_editors_gauge-legacy_percent_mode' into vis_editors…
6906b94 
…_gauge-custom_color
@Kuznietsov
Fixed tests types.
0b3b218
@Kuznietsov
Fixed case if uiState is undefined.
1471d0f
@Kuznietsov
Merge branch 'vis_editors_gauge-legacy_percent_mode' into vis_editors…
ade086a 
…_gauge-custom_color
@Kuznietsov
Fixed types.
c27c311
@Kuznietsov
Merge branch 'main' into vis_editors_gauge-custom_color
450c051 
# Conflicts:
#	src/plugins/chart_expressions/expression_gauge/common/types/expression_renderers.ts
#	src/plugins/chart_expressions/expression_gauge/public/components/gauge_component.test.tsx
#	src/plugins/chart_expressions/expression_gauge/public/components/gauge_component.tsx
#	src/plugins/chart_expressions/expression_gauge/public/expression_renderers/gauge_renderer.tsx
@Kuznietsov
Fixed wrong behavior of the coloring in the percentage mode
99b174a
@Kuznietsov Kuznietsov added backport:skip This commit does not require backporting impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort NeededFor:VisEditors release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0 and removed WIP Work in progress labels Mar 8, 2022
@Kuznietsov Kuznietsov marked this pull request as ready for review March 8, 2022 12:06
@Kuznietsov Kuznietsov requested a review from a team as a code owner March 8, 2022 12:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

stratoula
stratoula reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am importing an 8.1 gauge with all the band colors overwritten and I don't see them applied on the chart.

This is the gauge on 8,1
image

and this is the same chart on the new library
image

src/plugins/chart_expressions/expression_gauge/public/components/gauge_component.tsx Outdated Show resolved Hide resolved
src/plugins/chart_expressions/expression_gauge/public/components/gauge_component.tsx Outdated Show resolved Hide resolved
@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionGauge 9.7KB 10.3KB +579.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionGauge 14.8KB 14.8KB +18.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

stratoula
stratoula approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Yaroslav! Code LGTM. I tested it locally in Chrome.

@Kuznietsov Kuznietsov merged commit 2836018 into elastic:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@crob611 crob611 Awaiting requested review from crob611

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort NeededFor:VisEditors release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kuznietsov @elasticmachine @kibana-ci @stratoula @kibanamachine