Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gauge] Arc and Circle shapes. #125527

Merged
merged 29 commits into from
Feb 17, 2022
Merged

[Gauge] Arc and Circle shapes. #125527

merged 29 commits into from
Feb 17, 2022

Conversation

Kuznietsov
Copy link
Contributor

@Kuznietsov Kuznietsov commented Feb 14, 2022 •
edited
Loading

Summary

Completes part of the issue

  • Added circle shape.
  • Added arc shape.
  • Added empty results icon.
  • Added centralMajor and centralMajorMode support for the circle/arc shapes.
  • Added support of hidden option for the ticksPosition argument.

Screenshots:

Arc

Screenshot 2022-02-15 at 16 02 56

Circle

Screenshot 2022-02-15 at 16 03 39

ticksPosition

ticksPosition.mov

centralMajorMode

central.major.mode.mov

Validation of centralMajorMode and centralMajor support

shape.validation.mov

Kuznietsov and others added 20 commits February 8, 2022 12:20
@Kuznietsov
Fixed types, arguments, translation labels.
5cde4cc
@Kuznietsov
Fixed errors.
5d031c5
@kibanamachine
Merge branch 'main' into vis_editors_gauge-adaptation
baec880
@Kuznietsov
Shape argument turned to required.
45b009d
@Kuznietsov
Merge branch 'vis_editors_gauge-adaptation' of github.com:Kunzetsov/k…
4516fa9 
…ibana into vis_editors_gauge-adaptation

# Conflicts:
#	src/plugins/chart_expressions/expression_gauge/common/expression_functions/gauge_function.ts
@Kuznietsov
Fixed types mistake.
1290926
@Kuznietsov
Added checks for the gauge arguments.
09458f8
@Kuznietsov
Moved (metric/min/max/goal)Accessor arguments to (metric/min/max/goal).
daa6194
@Kuznietsov
Splited gauge and lens state.
7f55056
@Kuznietsov
Added support of vis_dimensions.
feba1c6
@Kuznietsov
Some fixes for uniformity.
de4b37f
@Kuznietsov
Tiny refactoring.
705e0a2
@kibanamachine
Merge branch 'main' into vis_editors_gauge-adaptation
81c04a8
@Kuznietsov
added new shapes.
e16626d
@Kuznietsov
Moved findAccessor out dimensions.
724c0fc
@Kuznietsov
Made accessors/vis_dimension functionality reusable for other plugins.
83683a8
@Kuznietsov
Fixed test snapshots.
3fd7ac1
@Kuznietsov
Fixed snapshots.
cca4e81
@Kuznietsov
Merge branch 'vis_editors_gauge-adaptation' into vis_editors_gauge-ne…
ae8a7a0 
…w-shapes
@Kuznietsov
Added support of arc and circle at the gauge shapes.
80b64dd
@Kuznietsov Kuznietsov added the WIP Work in progress label Feb 14, 2022
@Kuznietsov Kuznietsov self-assigned this Feb 14, 2022
@Kuznietsov Kuznietsov changed the title [WIP] [Gauge] Arc and Circle shapes added [WIP] [Gauge] Arc and Circle shapes. Feb 15, 2022
@Kuznietsov Kuznietsov changed the title [WIP] [Gauge] Arc and Circle shapes. [Gauge] Arc and Circle shapes. Feb 15, 2022
@Kuznietsov Kuznietsov added backport:skip This commit does not require backporting impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes v8.2.0 Feature:Lens NeededFor:VisEditors Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 15, 2022
@Kuznietsov
Merge branch 'main' into vis_editors_gauge-new-shapes
4edb9a8 
# Conflicts:
#	src/plugins/chart_expressions/expression_gauge/common/constants.ts
#	src/plugins/chart_expressions/expression_gauge/common/expression_functions/__snapshots__/gauge_function.test.ts.snap
#	src/plugins/chart_expressions/expression_gauge/common/expression_functions/gauge_function.test.ts
#	src/plugins/chart_expressions/expression_gauge/common/expression_functions/gauge_function.ts
#	src/plugins/chart_expressions/expression_gauge/common/types/expression_functions.ts
#	src/plugins/chart_expressions/expression_gauge/public/components/gauge_component.test.tsx
#	src/plugins/chart_expressions/expression_gauge/public/components/gauge_component.tsx
#	src/plugins/chart_expressions/expression_gauge/public/components/utils.test.ts
#	src/plugins/chart_expressions/expression_gauge/public/components/utils.ts
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionGauge 23 31 +8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressionGauge 66 68 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionGauge 8.6KB 8.9KB +307.0B
lens 1.1MB 1.1MB +2.0B
total +309.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
expressionGauge 2 3 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionGauge 11.6KB 13.7KB +2.2KB
Unknown metric groups

API count

id before after diff
expressionGauge 66 68 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov marked this pull request as ready for review February 16, 2022 13:05
@Kuznietsov Kuznietsov requested a review from a team as a code owner February 16, 2022 13:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@Kuznietsov Kuznietsov removed the WIP Work in progress label Feb 16, 2022
@mbondyra
Copy link
Contributor

mbondyra commented Feb 16, 2022 •
edited
Loading

There are some bugs I found for lens:

  1. No icons

Screenshot 2022-02-16 at 17 22 19

2. Doesn't load for the simplest case, I have no idea how functional tests didn't catch that 🤯 :

Screenshot 2022-02-16 at 17 23 05

@Kuznietsov
Copy link
Contributor Author

There are some bugs I found for lens:

  1. No icons
Screenshot 2022-02-16 at 17 22 19
  1. Doesn't load for the simplest case, I have no idea how functional tests didn't catch that 🤯 :
Screenshot 2022-02-16 at 17 23 05

Screenshot 2022-02-16 at 19 11 28

It seems to me, you need to do

yarn kbn bootstrap

or even clean.

@mbondyra
Copy link
Contributor

You're right @Kunzetsov, all works fine, approved!

@Kuznietsov Kuznietsov merged commit 12b3874 into elastic:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@crob611 crob611 Awaiting requested review from crob611

@flash1293 flash1293 Awaiting requested review from flash1293

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

@stratoula stratoula Awaiting requested review from stratoula

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort NeededFor:VisEditors release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kuznietsov @kibana-ci @elasticmachine @mbondyra @kibanamachine