-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some random fixes and more icons #427
Conversation
- eye & eyeClosed - grab - heatmap - vector
- Default button to text align left - No margins for <hr>
…iable if it is a color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I somewhat remember putting in the button left-align stuff at some point, and then we didn't do it for some reason (or maybe it just sat in a dead PR). I think you talked me out of it? I can't remember. But seems good.
Only thing we might want to change is make the loading spinner use an opacity for the "gray" part of the ring so that it always appears darker on whatever its used on. Right now it looks a little odd if its a darker gray background. Can do that later, no hurry.
CHANGELOG.md
Outdated
**Breaking changes** | ||
|
||
- Default `<button />` is now `text-align: left` ([#427](https://github.com/elastic/eui/pull/427)) | ||
- Changed `EuiAccordion`’s `onToggleOpen` to `onToggle` ([#427](https://github.com/elastic/eui/pull/427)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed EuiAccordion
’s prop of onToggleOpen
to onToggle
CHANGELOG.md
Outdated
|
||
**Breaking changes** | ||
|
||
- Default `<button />` is now `text-align: left` ([#427](https://github.com/elastic/eui/pull/427)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I think about it, I think we flipped on this because it broke something in Kibana directly. Lots of generic "button" tags there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm ok, I'll revert it
This reverts commit 72b06f5.
@snide I did you one better and I added a class to the spinner inside the button and colored it according to it's button's text color. |
Perfect. |
Added to reset.scss
<hr>
Bug fixes
isLoading
prop toEuiButton
onToggleOpen
is misleading #421 ChangedEuiAccordion
’sonToggleOpen
toonToggle
$euiCodeBlockSelectedBackgroundColor
variable if it is a colorMisc
Square instead of circle for indeterminate checkbox (and better error handlers in SASS)
Fix text-overflow on buttons (text-overflow property has to be on the first parent of the text).
EuiAccordion
. Gives more room for the button horizontally and lines up contents better.More icons