Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some random fixes and more icons #427

Merged
merged 11 commits into from
Feb 21, 2018
Merged

Some random fixes and more icons #427

merged 11 commits into from
Feb 21, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Feb 20, 2018

Added to reset.scss

  • Default button to text align left
  • No margins for <hr>

Bug fixes


Misc

  • Square instead of circle for indeterminate checkbox (and better error handlers in SASS)

  • Fix text-overflow on buttons (text-overflow property has to be on the first parent of the text).

screen shot 2018-02-20 at 16 33 11 pm

  • Remove left padding from form style EuiAccordion. Gives more room for the button horizontally and lines up contents better.

screen shot 2018-02-20 at 15 59 35 pm


More icons

  • eye & eyeClosed
  • grab
  • heatmap
  • vector

screen shot 2018-02-20 at 12 52 43 pm

@cchaos cchaos requested review from snide and cjcenizal February 20, 2018 21:34
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I somewhat remember putting in the button left-align stuff at some point, and then we didn't do it for some reason (or maybe it just sat in a dead PR). I think you talked me out of it? I can't remember. But seems good.

Only thing we might want to change is make the loading spinner use an opacity for the "gray" part of the ring so that it always appears darker on whatever its used on. Right now it looks a little odd if its a darker gray background. Can do that later, no hurry.

image

CHANGELOG.md Outdated
**Breaking changes**

- Default `<button />` is now `text-align: left` ([#427](https://github.com/elastic/eui/pull/427))
- Changed `EuiAccordion`’s `onToggleOpen` to `onToggle` ([#427](https://github.com/elastic/eui/pull/427))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed EuiAccordion’s prop of onToggleOpen to onToggle

CHANGELOG.md Outdated

**Breaking changes**

- Default `<button />` is now `text-align: left` ([#427](https://github.com/elastic/eui/pull/427))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think about it, I think we flipped on this because it broke something in Kibana directly. Lots of generic "button" tags there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm ok, I'll revert it

@cchaos
Copy link
Contributor Author

cchaos commented Feb 20, 2018

@snide I did you one better and I added a class to the spinner inside the button and colored it according to it's button's text color.

screen shot 2018-02-20 at 18 19 11 pm

@snide
Copy link
Contributor

snide commented Feb 20, 2018

Perfect.

@cchaos cchaos merged commit b48e578 into elastic:master Feb 21, 2018
@cchaos cchaos deleted the icons-fixes branch February 21, 2018 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants