Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection highlight of code is inconsistent #397

Closed
cchaos opened this issue Feb 13, 2018 · 0 comments · Fixed by #427
Closed

Selection highlight of code is inconsistent #397

cchaos opened this issue Feb 13, 2018 · 0 comments · Fixed by #427
Assignees

Comments

@cchaos
Copy link
Contributor

cchaos commented Feb 13, 2018

Some parts of the code coloring changes the color (or removes) the text highlight when the text is selected.

screen shot 2018-02-13 at 10 43 35 am

The issue stems from this selector:

.hljs > *::selection {
background-color: $euiCodeBlockSelectedBackgroundColor;
}

Which compiles to:

 .euiCodeBlock .hljs > *::selection {
    background-color: inherit;
}

Removing that selector fixes the highlighting. Or we need to give it an explicit value.

@cchaos cchaos self-assigned this Feb 20, 2018
cchaos pushed a commit to cchaos/eui that referenced this issue Feb 20, 2018
cchaos added a commit that referenced this issue Feb 21, 2018
* Added more icons

* No margins for <hr>

* Fix text-overflow on buttons

* #418 Add `isLoading` prop to `EuiButton`

* #421 Changed `EuiAccordion`’s `onToggleOpen` to `onToggle`

* #397 Only apply the `$euiCodeBlockSelectedBackgroundColor` variable if it is a color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant