Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiButton] Add isLoading property #418

Closed
pickypg opened this issue Feb 16, 2018 · 1 comment · Fixed by #427
Closed

[EuiButton] Add isLoading property #418

pickypg opened this issue Feb 16, 2018 · 1 comment · Fixed by #427
Assignees
@cchaos
Labels
feature request

Comments

@pickypg
Copy link
Member

pickypg commented Feb 16, 2018

As an analog to the KuiButton's isLoading attribute.

Once added, it should be easy to replace KuiButton.
@cchaos cchaos self-assigned this Feb 20, 2018
@snide
Copy link
Contributor

snide commented Feb 20, 2018

cc @cchaos This was the request for loading buttons I was mentioning. Would be nice for it to just be a prop like our form components.

cchaos pushed a commit to cchaos/eui that referenced this issue Feb 20, 2018
elastic#418 Add isLoading prop to EuiButton
a472425
@cchaos cchaos mentioned this issue Feb 20, 2018
Merged
cchaos added a commit that referenced this issue Feb 21, 2018
@cchaos
Some random fixes and more icons (#427)
b48e578 
* Added more icons

* No margins for <hr>

* Fix text-overflow on buttons

* #418 Add `isLoading` prop to `EuiButton`

* #421 Changed `EuiAccordion`’s `onToggleOpen` to `onToggle`

* #397 Only apply the `$euiCodeBlockSelectedBackgroundColor` variable if it is a color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cchaos cchaos

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some random fixes and more icons cchaos/eui
3 participants
@snide @cchaos @pickypg