Reinstate test cluster throttling behavior #88664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
@elasticmachine update branch |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jul 21, 2022
Co-authored-by: Elastic Machine <[email protected]>
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 21, 2022
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jul 22, 2022
* upstream/master: (40 commits) Fix CI job naming [ML] disallow autoscaling downscaling in two trained model assignment scenarios (elastic#88623) Add "Vector Search" area to changelog schema [DOCS] Update API key API (elastic#88499) Enable the pipeline on the feature branch (elastic#88672) Adding the ability to register a PeerFinderListener to Coordinator (elastic#88626) [DOCS] Fix transform painless example syntax (elastic#88364) [ML] Muting InternalCategorizationAggregationTests testReduceRandom (elastic#88685) Fix double rounding errors for disk usage (elastic#88683) Replace health request with a state observer. (elastic#88641) [ML] Fail model deployment if all allocations cannot be provided (elastic#88656) Upgrade to OpenJDK 18.0.2+9 (elastic#88675) [ML] make bucket_correlation aggregation generally available (elastic#88655) Adding cardinality support for random_sampler agg (elastic#86838) Use custom task instead of generic AckedClusterStateUpdateTask (elastic#88643) Reinstate test cluster throttling behavior (elastic#88664) Mute testReadBlobWithPrematureConnectionClose Simplify plugin descriptor tests (elastic#88659) Add CI job for testing more job parallelism [ML] make deployment infer requests fully cancellable (elastic#88649) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of #85141 upgrading to Gradle 7.5 we lost some previous behavior related to test cluster parallelism. Previously, when we registered a resource lock we also provided how many leases we were requesting. The reason for this is that some tests spin up a single node cluster and others multi-node clusters. To differentiate between these tasks we count each node as a lease towards to total allowed concurrent leases.
Since there's no longer an explicit API for this in Gradle 7.5, the
hackworkaround is simply to register multiple locks from the same shared resource. I've tested this locally in a simple standalone project to better demonstrate that the approach does indeed work as intended.https://gradle-enterprise.elastic.co/s/2xgmqx2ika5si/timeline