Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to to Gradle wrapper 7.5 #85141

Merged
merged 33 commits into from
Jul 19, 2022
Merged

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Mar 20, 2022

This updates the gradle wrapper to a 7.5

Fixes #85123

@breskeby breskeby self-assigned this Mar 20, 2022
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement build-benchmark Trigger build benchmark job Team:Delivery Meta label for Delivery team v7.17.2 v8.1.1 v8.2.0 and removed v8.1.1 build-benchmark Trigger build benchmark job labels Mar 20, 2022
@breskeby
Copy link
Contributor Author

run elasticsearch-ci/build-benchmark-part1

@breskeby
Copy link
Contributor Author

elasticsearch-ci/build-benchmark-part2

@breskeby breskeby marked this pull request as ready for review March 20, 2022 21:14
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/build-benchmark-part2

@breskeby
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/build-benchmark-part1

@breskeby breskeby changed the title Update to to Gradle wrapper 7.5 WIP - Update to to Gradle wrapper 7.5 Mar 20, 2022
@breskeby breskeby marked this pull request as draft March 20, 2022 21:16
@breskeby
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/build-benchmark

@breskeby breskeby force-pushed the update-to-gradle-7-5 branch 4 times, most recently from 9e06953 to 961acc0 Compare March 23, 2022 11:19
@arteam arteam added v7.17.3 and removed v7.17.2 labels Mar 28, 2022
@breskeby breskeby force-pushed the update-to-gradle-7-5 branch from eb2ad52 to 3bb74a8 Compare March 29, 2022 10:30
@breskeby breskeby force-pushed the update-to-gradle-7-5 branch from 7f94776 to 501a0fa Compare April 1, 2022 13:49
@breskeby breskeby force-pushed the update-to-gradle-7-5 branch from cb6ffc7 to e058d3e Compare July 15, 2022 01:09
@breskeby breskeby marked this pull request as ready for review July 15, 2022 06:32
@breskeby
Copy link
Contributor Author

7.5 has finally landed. The change in checkstyle using the worker api seems to have quite an impact on the performance.

The benchmark results compared to 7.4.2 we run:
Screenshot 2022-07-15 at 08 30 29
Screenshot 2022-07-15 at 08 31 30

breskeby added 3 commits July 15, 2022 12:21
Removing overhead of making this 7.4.2 compliant in order to have benchmark builds working
with both versions.
Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breskeby breskeby merged commit 98b789c into elastic:master Jul 19, 2022
@breskeby breskeby deleted the update-to-gradle-7-5 branch July 19, 2022 06:12
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jul 19, 2022
This updates the gradle wrapper to a 7.5

Fixes elastic#85123
# Conflicts:
#	build-tools-internal/build.gradle
#	build-tools-internal/performance/elasticsearch-build-benchmark-part1.scenarios
#	build-tools-internal/performance/elasticsearch-build-benchmark-part2.scenarios
#	build-tools/src/main/java/org/elasticsearch/gradle/testclusters/StandaloneRestIntegTestTask.java
breskeby added a commit that referenced this pull request Jul 19, 2022
Backports the following commits to 7.17:
 - Update to to Gradle wrapper 7.5 (#85141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-benchmark Trigger build benchmark job :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.17.3 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Gradle wrapper to 7.5
6 participants