Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix transform painless example syntax #88364

Merged

Conversation

eltomello
Copy link
Contributor

The syntax of the painless code in the scripted metric aggregation example is wrong.

@elasticsearchmachine elasticsearchmachine added v8.4.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jul 8, 2022
@DJRickyB DJRickyB added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Jul 12, 2022
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@stu-elastic stu-elastic added the >docs General docs changes label Jul 12, 2022
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jul 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the fix @eltomello

@jdconrad jdconrad self-assigned this Jul 21, 2022
@jdconrad
Copy link
Contributor

@elasticmachine test this please

@jdconrad jdconrad merged commit df7ea6a into elastic:master Jul 21, 2022
jdconrad pushed a commit to jdconrad/elasticsearch that referenced this pull request Jul 21, 2022
Corrects the syntax of an example for a scripted metric aggregation.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.3

elasticsearchmachine pushed a commit that referenced this pull request Jul 21, 2022
Corrects the syntax of an example for a scripted metric aggregation.

Co-authored-by: eltomello <[email protected]>
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 22, 2022
* upstream/master: (40 commits)
  Fix CI job naming
  [ML] disallow autoscaling downscaling in two trained model assignment scenarios (elastic#88623)
  Add "Vector Search" area to changelog schema
  [DOCS] Update API key API (elastic#88499)
  Enable the pipeline on the feature branch (elastic#88672)
  Adding the ability to register a PeerFinderListener to Coordinator (elastic#88626)
  [DOCS] Fix transform painless example syntax (elastic#88364)
  [ML] Muting InternalCategorizationAggregationTests testReduceRandom (elastic#88685)
  Fix double rounding errors for disk usage (elastic#88683)
  Replace health request with a state observer. (elastic#88641)
  [ML] Fail model deployment if all allocations cannot be provided (elastic#88656)
  Upgrade to OpenJDK 18.0.2+9 (elastic#88675)
  [ML] make bucket_correlation aggregation generally available (elastic#88655)
  Adding cardinality support for random_sampler agg (elastic#86838)
  Use custom task instead of generic AckedClusterStateUpdateTask (elastic#88643)
  Reinstate test cluster throttling behavior (elastic#88664)
  Mute testReadBlobWithPrematureConnectionClose
  Simplify plugin descriptor tests (elastic#88659)
  Add CI job for testing more job parallelism
  [ML] make deployment infer requests fully cancellable (elastic#88649)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v8.3.0 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants