ExistsQueryBuilder to no longer rely on getMatchingFieldTypes #73617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been discussing possibly removing `FieldTypeLookup#getMatchingFieldTypes`, or at least its `SearchExecutionContext` variant that applies runtime mappings. This is another step in that direction: the exists query can rely on getMatchingFieldNames instead, and look up field types by name.
javanna
added
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
This was referenced Jun 1, 2021
jtibshirani
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
This makes sense to me. It seems we need either getMatchingFieldNames or getMatchingFieldTypes, but certainly not both.
To check I understand the plan -- will we follow up with a change to remove/ rework getMatchingFieldTypes completely? Edit: nevermind, I just saw #73618 :)
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Jun 2, 2021
…c#73617) We've been discussing possibly removing `FieldTypeLookup#getMatchingFieldTypes`, or at least its `SearchExecutionContext` variant that applies runtime mappings. This is another step in that direction: the exists query can rely on getMatchingFieldNames instead, and look up field types by name.
javanna
added a commit
that referenced
this pull request
Jun 2, 2021
We've been discussing possibly removing `FieldTypeLookup#getMatchingFieldTypes`, or at least its `SearchExecutionContext` variant that applies runtime mappings. This is another step in that direction: the exists query can rely on getMatchingFieldNames instead, and look up field types by name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been discussing possibly removing
FieldTypeLookup#getMatchingFieldTypes, or at least itsSearchExecutionContextvariant that applies runtime mappings, as it adds complexity and has only a few usages.This is another step in that direction: the exists query can rely on
getMatchingFieldNamesinstead, and look up field types by name.