FieldTypeLookup#getMatchingFieldTypes to rely on getMatchingFieldNames #73590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getMatchingFieldTypes has its own logic, that is more or less duplicated from getMatchingFieldNames. We have been talking about removing getMatchingFieldTypes but there are a couple of leftover usages. What we can do instead is make it rely on the getMatchingFieldNames logic so that we remove the code duplication.
javanna
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
|
I think that I found a way to remove getMatchingFieldTypes, starting with #73617. That means no review is needed here, I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getMatchingFieldTypes has its own logic, that is more or less duplicated from getMatchingFieldNames. We have been talking about removing getMatchingFieldTypes but there are a couple of leftover usages. What we can do instead is make it rely on the getMatchingFieldNames logic so that we remove the code duplication.