Introduce specialized getMatchingFieldTypes that takes a predicate #73618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would like to reduce usages of FieldTypeLookup#getMatchingFieldTypes. The method is used for two main different reasons:
1) exists query builder to check whether a field exists or not
2) to iterate through all field types (`getMatchingFieldTypes("*")` is called internally) and then filter them based on different criteria: this is used to eagerly load global ordinals and find the join field type
The latter use-case could use a more specialized method, which makes it easier to trace. Additionally this scenario does not need to have runtime mappings applied in `SearchExecutionContext` which simplifies things further as the method can simply proxy to the corresponding `MappingLookup#getMatchingFieldTypes`.
javanna
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
javanna
commented
Jun 1, 2021
| for (String knownSubfield : dft.getKnownSubfields()) { | ||
| childFieldTypes.add(dft.getChildFieldType(knownSubfield)); | ||
| } | ||
| return childFieldTypes.stream(); |
There was a problem hiding this comment.
I am thinking that probably, given the current usages of this method, the dynamic field type step can be skipped. getKnownSubfields was just introduced for #73252, and eager global ordinals and join field type (where this method is called) have nothing to do with runtime fields.
|
Closing in favour of #73655 which takes a different approach by reusing the index time lookup that's already available within MappingLookup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to reduce usages of FieldTypeLookup#getMatchingFieldTypes. The method is used for two main different reasons:
getMatchingFieldTypes("*")is called internally) and then filter them based on different criteria: this is used to eagerly load global ordinals and find the join field typeThe latter use-case could use a more specialized method, which makes it easier to trace. Additionally this scenario does not need to have runtime mappings applied in
SearchExecutionContextwhich simplifies things further as the method can simply proxy to the correspondingMappingLookup#getMatchingFieldTypes.