Change default format for date_nanos field #70463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the default format of date_nanos field on existing and new indices to use `strict_date_optional_time_nanos` instead of `strict_date_optional_time`. Using `strict_date_optional_time` as the default format for date_nanos doesn't make sense because it accepts and parses dates with nanosecond precision, but when it formats it drops the nanoseconds. The change should be transparent for users, these formats accept the same input. Relates elastic#69192 Closes elastic#67063
jimczi
added
>enhancement
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
jtibshirani
reviewed
Mar 16, 2021
server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java
Outdated
Show resolved
Hide resolved
jtibshirani
approved these changes
Mar 16, 2021
jimczi
added a commit
that referenced
this pull request
Mar 17, 2021
This commit updates the default format of date_nanos field on existing and new indices to use `strict_date_optional_time_nanos` instead of `strict_date_optional_time`. Using `strict_date_optional_time` as the default format for date_nanos doesn't make sense because it accepts and parses dates with nanosecond precision, but when it formats it drops the nanoseconds. The change should be transparent for users, these formats accept the same input. Relates #69192 Closes #67063
jimczi
added a commit
that referenced
this pull request
Mar 18, 2021
This commit updates the default format of date_nanos field on existing and new indices to use `strict_date_optional_time_nanos` instead of `strict_date_optional_time`. Using `strict_date_optional_time` as the default format for date_nanos doesn't make sense because it accepts and parses dates with nanosecond precision, but when it formats it drops the nanoseconds. The change should be transparent for users, these formats accept the same input. Relates #69192 Closes #67063
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Mar 25, 2021
This change rewrites the rolling upgrade yml test that was added for date_nanos in Java. This is needed to allow extra logic when backporting to 7.x. date_nanos are not available in 6.x so we need to skip the upgraded test based on the version of the old cluster. Relates elastic#70463
jimczi
added a commit
that referenced
this pull request
Mar 26, 2021
This change rewrites the rolling upgrade yml test that was added for date_nanos in Java. This is needed to allow extra logic when backporting to 7.x. date_nanos are not available in 6.x so we need to skip the upgraded test based on the version of the old cluster. Relates #70463
jimczi
added a commit
that referenced
this pull request
Mar 26, 2021
This change rewrites the rolling upgrade yml test that was added for date_nanos in Java. This is needed to allow extra logic when backporting to 7.x. date_nanos are not available in 6.x so we need to skip the upgraded test based on the version of the old cluster. Relates #70463
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the default format of date_nanos field
on existing and new indices to use
strict_date_optional_time_nanosinstead ofstrict_date_optional_time.Using
strict_date_optional_timeas the default format for date_nanos doesn'tmake sense because it accepts and parses dates with nanosecond precision,
but when it formats it drops the nanoseconds.
The change should be transparent for users, these formats accept the same input.
Relates #69192
Closes #67063