Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strict_date_optional_time to print nanoseconds #67893

Closed
wants to merge 2 commits into from
Closed

strict_date_optional_time to print nanoseconds #67893

wants to merge 2 commits into from

Conversation

pgomulka
Copy link
Contributor

strict_date_optional_time is allowing to parse nanoseconds up to 9digis,
but is only printing up to 3digits.
This is enought for date field, but not sufficient for date_nanos
This commit is chaning the printer in strict_date_optional_time to
print up to 9 digits

closes #67063

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
strict_date_optional_time to print nanoseconds
2c6a3b2 
strict_date_optional_time is allowing to parse nanoseconds up to 9digis,
but is only printing up to 3digits.
This is enought for date field, but not sufficient for date_nanos
This commit is chaning the printer in `strict_date_optional_time` to
print up to 9 digits

closes elastic#67063
@pgomulka pgomulka self-assigned this Jan 25, 2021
@pgomulka pgomulka added the :Core/Infra/Core Core issues without another label label Jan 25, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jan 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@gwbrown gwbrown mentioned this pull request Jan 26, 2021
Closed
@mark-vieira
Copy link
Contributor

@elasticmachine update branch

@pgomulka
Copy link
Contributor Author

pgomulka commented Feb 3, 2021

ok to test

@pgomulka pgomulka mentioned this pull request Feb 3, 2021
Closed
@mattkime mattkime mentioned this pull request Feb 5, 2021
Closed
9 tasks
@pgomulka
Copy link
Contributor Author

pgomulka commented Feb 11, 2021 •
edited
Loading

ok to test

@pgomulka
Copy link
Contributor Author

pgomulka commented Mar 17, 2021 •
edited
Loading

closed in favour of #70463

@pgomulka pgomulka closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve default format for date_nanos fields
5 participants
@pgomulka @elasticmachine @mark-vieira @jakelandis @williamrandolph