Rewrite date_nanos rolling upgrade test #70855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change rewrites the rolling upgrade yml test that was added for date_nanos in Java. This is needed to allow extra logic when backporting to 7.x. date_nanos are not available in 6.x so we need to skip the upgraded test based on the version of the old cluster. Relates elastic#70463
jimczi
added
>test
|
Pinging @elastic/es-search (Team:Search) |
|
ci failed on a known issue |
|
@elasticmachine run elasticsearch-ci/2 |
dnhatn
approved these changes
Mar 26, 2021
| @@ -171,6 +166,62 @@ public void testAutoIdWithOpTypeCreate() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| public void testDateNanosFormatUpgrade() throws IOException { | |||
| final String indexName = "test_date_nanos"; | |||
| switch (CLUSTER_TYPE) { | |||
There was a problem hiding this comment.
I think we can use UPGRADE_FROM_VERSION instead of minNodeVersion as we do not execute anything in a mixed cluster.
There was a problem hiding this comment.
++, I use it in the backport to disable the test with 6.8 (date_nanos was added in 7.0).
jimczi
added a commit
that referenced
this pull request
Mar 26, 2021
This change rewrites the rolling upgrade yml test that was added for date_nanos in Java. This is needed to allow extra logic when backporting to 7.x. date_nanos are not available in 6.x so we need to skip the upgraded test based on the version of the old cluster. Relates #70463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change rewrites the rolling upgrade yml test that was added for
date_nanos in Java. This is needed to allow extra logic when backporting to
7.x. date_nanos are not available in 6.x so we need to skip the upgraded test
based on the version of the old cluster.
Relates #70463