[ML] add default inference config to lang ident model #65986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
benwtrent
commented
Dec 7, 2020
| @@ -105,7 +105,7 @@ | |||
| public static final String MODEL_DEFINITION_NOT_FOUND = "Could not find trained model definition [{0}]"; | |||
| public static final String MODEL_METADATA_NOT_FOUND = "Could not find trained model metadata {0}"; | |||
| public static final String INFERENCE_CANNOT_DELETE_MODEL = | |||
| "Unable to delete model [{0}]"; | |||
| "Unable to delete model [{0}] as it is self-contained in the machine learning plugin"; | |||
There was a problem hiding this comment.
@sophiec20 I am open to better suggestions here.
There was a problem hiding this comment.
The string INFERENCE_CANNOT_DELETE_MODEL is named generically as if the the message could apply to any model but it is strictly about ml models.
I see it is only used in one place but can you rename to INFERENCE_CANNOT_DELETE_*ML*_MODEL or something pls.
Suggestions:
"... as it is managed by machine learning"
There was a problem hiding this comment.
Suggest Cannot delete built-in model [{0}] as it is required by machine learning
…eld-to-lang-ident-model
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Dec 8, 2020
This adds a default `inference_config` object to the stored lang ident model. This doesn't change behavior as there are no default settings set in the config. Additionally, when serializing over the wire in older versions, we handle bwc. This commit also slightly changes the error message when a model stored as a resource is attempted to be deleted. relates: elastic/kibana#85179
benwtrent
added a commit
that referenced
this pull request
Dec 9, 2020
This adds a default `inference_config` object to the stored lang ident model. This doesn't change behavior as there are no default settings set in the config. Additionally, when serializing over the wire in older versions, we handle bwc. This commit also slightly changes the error message when a model stored as a resource is attempted to be deleted. relates: elastic/kibana#85179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a default
inference_configobject to the stored lang ident model.This doesn't change behavior as there are no default settings set in the config.
Additionally, when serializing over the wire in older versions, we handle bwc.
This commit also slightly changes the error message when a model stored as a resource is attempted to be deleted.
relates: elastic/kibana#85179