Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [ML] add default inference config to lang ident model (#65986) #66038

Merged
merged 1 commit into from
Dec 9, 2020
Merged

[7.x] [ML] add default inference config to lang ident model (#65986) #66038

merged 1 commit into from
Dec 9, 2020

Conversation

benwtrent
Copy link
Member

Backports the following commits to 7.x:

@benwtrent
[ML] add default inference config to lang ident model (elastic#65986)
7efedbe 
This adds a default `inference_config` object to the stored lang ident model.

This doesn't change behavior as there are no default settings set in the config.

Additionally, when serializing over the wire in older versions, we handle bwc.

This commit also slightly changes the error message when a model stored as a resource is attempted to be deleted.

relates: elastic/kibana#85179
@benwtrent benwtrent added :ml Machine learning backport labels Dec 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent benwtrent merged commit 41285a6 into elastic:7.x Dec 9, 2020
@benwtrent benwtrent deleted the backport/7.x/pr-65986 branch December 9, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport :ml Machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benwtrent @elasticmachine