Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] add default inference config to lang ident model #65986

Merged
merged 4 commits into from
Dec 8, 2020
Merged

[ML] add default inference config to lang ident model #65986

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
431bf37
[ML] add default inference config to lang ident model
benwtrent Dec 7, 2020
bff8593
addressing pr comments
benwtrent Dec 8, 2020
3c48e56
Merge remote-tracking branch 'upstream/master' into feature/ml-add-fi…
benwtrent Dec 8, 2020
cabdaf7
fixing format
benwtrent Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/messages/Messages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public final class Messages {
public static final String MODEL_DEFINITION_NOT_FOUND = "Could not find trained model definition [{0}]";
public static final String MODEL_METADATA_NOT_FOUND = "Could not find trained model metadata {0}";
public static final String INFERENCE_CANNOT_DELETE_MODEL =
"Unable to delete model [{0}]";
"Unable to delete model [{0}] as it is self-contained in the machine learning plugin";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sophiec20 I am open to better suggestions here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string INFERENCE_CANNOT_DELETE_MODEL is named generically as if the the message could apply to any model but it is strictly about ml models.

I see it is only used in one place but can you rename to INFERENCE_CANNOT_DELETE_*ML*_MODEL or something pls.

Suggestions:
"... as it is managed by machine learning"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest Cannot delete built-in model [{0}] as it is required by machine learning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

public static final String MODEL_DEFINITION_TRUNCATED =
"Model definition truncated. Unable to deserialize trained model definition [{0}]";
public static final String INFERENCE_FAILED_TO_DESERIALIZE = "Could not deserialize trained model [{0}]";
Expand Down
1 change: 1 addition & 0 deletions ...c/main/resources/org/elasticsearch/xpack/ml/inference/persistence/lang_ident_model_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"text"
]
},
"inference_config" : {"classification" : {}},
"estimated_heap_memory_usage_bytes" : 1053992,
"estimated_operations" : 39629,
"license_level" : "basic"
Expand Down