[DOCS] Change ctx.payload.hits.total.value to ctx.payload.hits.total
#65874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ctx.payload.hits.total.value` is no longer valid. The proper way to get the total hits is `ctx.payload.hits.total`
|
@elasticmachine update branch |
jrodewig
added
:Data Management/Watcher
>docs
elasticmachine
added
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
Pinging @elastic/es-docs (Team:Docs) |
jrodewig
changed the title
ctx.payload.hits.total.value to ctx.payload.hits.total
jakelandis
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
LGTM. FWIW the total.value is what is required if rest_total_hits_as_int is set to false. It defaults to true today, but will likely default to false for 8.0: #38387
Also, it turns out that you can't actually store a watch with rest_total_hits_as_int is set to false today: #65988
If/when we implement #38387 we will need to change this documentation back to using .value ...but I agree for now lets document the default
|
Thanks @jakelandis. |
This was referenced Dec 8, 2020
Merged
jrodewig
added a commit
that referenced
this pull request
Dec 8, 2020
…al` (#65874) (#66032) Co-authored-by: James Rodewig <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Ernesto Reig <[email protected]>
jrodewig
added a commit
that referenced
this pull request
Dec 8, 2020
…al` (#65874) (#66031) Co-authored-by: James Rodewig <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Ernesto Reig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctx.payload.hits.total.valueis no longer valid. The proper way to get the total hits isctx.payload.hits.total