Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watcher - ensure that rest_total_hits_as_int is persisted #65988

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Watcher - ensure that rest_total_hits_as_int is persisted #65988

merged 2 commits into from
Dec 8, 2020

Conversation

jakelandis
Copy link
Contributor

A minor logic bug only persists the rest_total_hits_as_int
option for Watch search inputs if the value is true.

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Dec 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@jakelandis jakelandis requested a review from martijnvg December 7, 2020 22:28
@jakelandis
Copy link
Contributor Author

@elasticmachine update branch

martijnvg
martijnvg approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakelandis jakelandis merged commit 12c14ce into elastic:master Dec 8, 2020
@jakelandis jakelandis deleted the watcher_persist_total_as_int branch December 8, 2020 14:02
@jakelandis jakelandis mentioned this pull request Dec 8, 2020
Merged
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Dec 8, 2020
@jakelandis
Watcher - ensure that rest_total_hits_as_int is persisted (elastic#65988
4439980 
)

A minor logic bug only persists the rest_total_hits_as_int
option for Watch search inputs if the value is true.
# Conflicts:
#	x-pack/plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/support/search/WatcherSearchTemplateRequest.java
jakelandis added a commit that referenced this pull request Dec 8, 2020
@jakelandis
[7.x] Watcher - ensure that rest_total_hits_as_int is persisted (#65988…
4c9b9b8 
…) (#66029)

A minor logic bug only persists the rest_total_hits_as_int
option for Watch search inputs if the value is true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees
No one assigned
Labels
>bug :Data Management/Watcher Team:Data Management Meta label for data/management team v7.11.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakelandis @elasticmachine @martijnvg