Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher: remove rest_total_hits_as_int #38387

Closed
jakelandis opened this issue Feb 5, 2019 · 3 comments
Closed

Watcher: remove rest_total_hits_as_int #38387

jakelandis opened this issue Feb 5, 2019 · 3 comments
Labels

Comments

@jakelandis
Copy link
Contributor

In 7.x the total hits in the search response were changed (#33028). To preserve compatibility watcher set rest_total_hits_as_int (#35848) to true by default to opt-out of the new response format (#36115).

Prior to 8.x Watcher needs to define a strategy to properly deprecate, and possibly re-write existing watches to no longer have rest_total_hits_as_int as the default (in 7.x it can be changed per watch, but defaults to true if not set). The strategy also needs to account for any other Elastic stack components, such as monitoring and beats that may use Watcher hit counts.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@jakelandis
Copy link
Contributor Author

Reminder to update the documentation to use total.value when this change is implemented: #65874

@jimczi - are there still plans to remove and/or deprecate rest_total_hits_as_int for 8.0 ?

@dakrone
Copy link
Member

dakrone commented May 8, 2024

This has been open for quite a while, and we haven't made much progress on this due to focus in other areas. For now I'm going to close this as something we aren't planning on implementing. We can re-open it later if needed.

@dakrone dakrone closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants