Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TranslogTests#testWithRandomException #51712

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Fix TranslogTests#testWithRandomException #51712

merged 1 commit into from
Jan 31, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 30, 2020

Before #51417, trimUnreferencedReaders in this test was a noop as the default translog retention policy was 512MB and 12h, which was long enough to keep all translog files. Two problems in this test:

  • We do not consider any failure while trimming unreferenced readers as a tragedy.
  • We should clear the synced list before calling trimUnreferencedReaders.

Relates #51505
Closes #51694

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 labels Jan 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

ywelsch
ywelsch approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

henningandersen
henningandersen approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@dnhatn
Copy link
Member Author

dnhatn commented Jan 31, 2020

Thanks Yannick + Henning.

@dnhatn dnhatn merged commit 60f8941 into elastic:master Jan 31, 2020
@dnhatn dnhatn deleted the fix-translog branch January 31, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

@henningandersen henningandersen henningandersen approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] TranslogTests.testWithRandomException
5 participants
@dnhatn @elasticmachine @ywelsch @henningandersen @jakelandis