Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] TranslogTests.testWithRandomException #51694

Closed
jpountz opened this issue Jan 30, 2020 · 1 comment · Fixed by #51712
Closed

[CI] TranslogTests.testWithRandomException #51694

jpountz opened this issue Jan 30, 2020 · 1 comment · Fixed by #51712
Assignees
@dnhatn
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test-failure Triaged test failures from CI

Comments

@jpountz
Copy link
Contributor

jpountz commented Jan 30, 2020

Found by PR testing but there were other instances in CI:
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-darwin-compatibility/482/console

07:59:00 org.elasticsearch.index.translog.TranslogTests > testWithRandomException FAILED
07:59:00     java.lang.AssertionError: expected:<3> but was:<0>
07:59:00         at __randomizedtesting.SeedInfo.seed([AD75FA3DC5C69916:CBAD9122BE221707]:0)
07:59:00         at org.junit.Assert.fail(Assert.java:88)
07:59:00         at org.junit.Assert.failNotEquals(Assert.java:834)
07:59:00         at org.junit.Assert.assertEquals(Assert.java:645)
07:59:00         at org.junit.Assert.assertEquals(Assert.java:631)
07:59:00         at org.elasticsearch.index.translog.TranslogTests.testWithRandomException(TranslogTests.java:2726)
07:59:01 REPRODUCE WITH: ./gradlew ':server:test' --tests "org.elasticsearch.index.translog.TranslogTests.testWithRandomException" -Dtests.seed=AD75FA3DC5C69916 -Dtests.security.manager=true -Dtests.locale=zh-Hans-CN -Dtests.timezone=IET -Dcompiler.java=13
@jpountz jpountz added >test-failure Triaged test failures from CI :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. labels Jan 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

@jpountz jpountz mentioned this issue Jan 30, 2020
Merged
@dnhatn dnhatn self-assigned this Jan 30, 2020
@dnhatn dnhatn mentioned this issue Jan 30, 2020
Merged
dnhatn added a commit that referenced this issue Jan 31, 2020
@dnhatn
Fix Translog#testWithRandomException (#51712)
60f8941 
Before #51417, trimUnreferencedReaders in this test was a noop as the 
default translog retention policy was 512MB and 12h, which was long 
enough to keep all translog files. Two problems in this test:

- We do not consider any failure while trimming unreferenced readers as 
  a tragedy.

- We should clear the synced list before calling 
  trimUnreferencedReaders.

Relates #51505
Closes #51694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnhatn dnhatn

Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TranslogTests#testWithRandomException dnhatn/elasticsearch
3 participants
@jpountz @dnhatn @elasticmachine