Always use bundled JDK for external cluster nodes when BWC testing #51505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Vieira <[email protected]>
Signed-off-by: Mark Vieira <[email protected]>
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Signed-off-by: Mark Vieira <[email protected]>
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/2 |
|
@elasticmachine run elasticsearch-ci/default-distro |
|
@elasticmachine run elasticsearch-ci/1 |
This was referenced Jan 28, 2020
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 30, 2020
mark-vieira
added a commit
that referenced
this pull request
Jan 30, 2020
mark-vieira
added a commit
that referenced
this pull request
Jan 30, 2020
This was referenced Jan 30, 2020
dnhatn
added a commit
that referenced
this pull request
Jan 31, 2020
Before #51417, trimUnreferencedReaders in this test was a noop as the default translog retention policy was 512MB and 12h, which was long enough to keep all translog files. Two problems in this test: - We do not consider any failure while trimming unreferenced readers as a tragedy. - We should clear the synced list before calling trimUnreferencedReaders. Relates #51505 Closes #51694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the configured runtime Java home when running Elasticsearch nodes used for BWC testing. This can cause issues when a BWC version doesn't support running with the current branches runtime Java. For example, we want to test
masteron Java 15 but existing7.xreleases explode due to the removal of CMS garbage collector options in Java 15. Realistically, we should just be running those nodes using their bundled JDK. This pull request does exactly that, and simply removes all setting ofJAVA_HOMEfor test clusters that are not the current elasticsearch version.Note: Backporting this will involve some extra work since in
7.x, we spin up BWC test clusters that do not bundle a JDK, so we will need to boostrap one somehow.Closes #51361