Deprecate the 'local' parameter of /_cat/nodes #50499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
|
@elasticmachine ok to test. |
DaveCTurner
requested changes
Jan 2, 2020
There was a problem hiding this comment.
Good work @olegbonar. I left some suggestions re. docs and messages but nothing major.
rest-api-spec/src/main/resources/rest-api-spec/api/cat.nodes.json
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/cat.nodes.json
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/rest/action/cat/RestNodesAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/rest/action/cat/RestNodesAction.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/rest/action/cat/RestNodesActionTests.java
Outdated
Show resolved
Hide resolved
DaveCTurner
added
>enhancement
v7.6.0
v8.0.0
>deprecation
and removed
>enhancement
labels
Co-Authored-By: David Turner <[email protected]>
|
@elasticmachine update branch |
|
Thanks @olegbonar, I've merged this and will backport it to |
DaveCTurner
pushed a commit
that referenced
this pull request
Jan 2, 2020
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`. Today it accepts the `?local` parameter and passes this to the `ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`. This is surprising, because `GET _cat/nodes?local` looks like it might be a completely local call but in fact it still depends on every node in the cluster. This commit deprecates the `?local` parameter on this API so that it can be removed in 8.0. Relates #50088
|
Backported as 7539fbb. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 2, 2020
In elastic#50499 we accidentally duplicated the docs for the `?local` parameter to the `GET _cat/nodes` API. This commit removes the duplicate docs.
Merged
DaveCTurner
added a commit
that referenced
this pull request
Jan 2, 2020
In #50499 we accidentally duplicated the docs for the `?local` parameter to the `GET _cat/nodes` API. This commit removes the duplicate docs.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 3, 2020
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`. Today it accepts the `?local` parameter and passes this to the `ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`. This is surprising, because `GET _cat/nodes?local` looks like it might be a completely local call but in fact it still depends on every node in the cluster. This parameter was deprecated in 7.x in elastic#50499 and this commit removes it. Relates elastic#50088
|
I opened #50594 to remove the parameter in 8.0. |
DaveCTurner
added a commit
that referenced
this pull request
Jan 6, 2020
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`. Today it accepts the `?local` parameter and passes this to the `ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`. This is surprising, because `GET _cat/nodes?local` looks like it might be a completely local call but in fact it still depends on every node in the cluster. This parameter was deprecated in 7.x in #50499 and this commit removes it. Relates #50088
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`. Today it accepts the `?local` parameter and passes this to the `ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`. This is surprising, because `GET _cat/nodes?local` looks like it might be a completely local call but in fact it still depends on every node in the cluster. This commit deprecates the `?local` parameter on this API so that it can be removed in 8.0. Relates elastic#50088
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`. Today it accepts the `?local` parameter and passes this to the `ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`. This is surprising, because `GET _cat/nodes?local` looks like it might be a completely local call but in fact it still depends on every node in the cluster. This parameter was deprecated in 7.x in elastic#50499 and this commit removes it. Relates elastic#50088
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cat nodes API performs a
ClusterStateActionthen aNodesInfoAction.Today it accepts the
?localparameter and passes this to theClusterStateActionbut this parameter has no effect on theNodesInfoAction.This is surprising, because
GET _cat/nodes?locallooks like it might be acompletely local call but in fact it still depends on every node in the
cluster.
This commit deprecates the
?localparameter on this API so that it can beremoved in 8.0.
Relates #50088