Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove included docs #50557

Merged

Conversation

DaveCTurner
Copy link
Contributor

In #50499 we accidentally duplicated the docs for the ?local parameter to the
GET _cat/nodes API. This commit removes the duplicate docs.

In elastic#50499 we accidentally duplicated the docs for the `?local` parameter to the
`GET _cat/nodes` API. This commit removes the duplicate docs.
@DaveCTurner DaveCTurner added >docs General docs changes :Core/Infra/Core Core issues without another label v7.6.0 labels Jan 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

deprecated:[7.6.0,This parameter does not cause this API to act locally. It will be removed in version 8.0.]
If `true`, the request computes the list of selected nodes from the local
cluster state. Defaults to `false`, which means the list of selected nodes is
computed from the cluster state on the master node. In either case the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it: needs a , after "In either case" doesn't it? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think it's acceptable (and better) as it is.

@DaveCTurner DaveCTurner merged commit b209e7b into elastic:7.x Jan 2, 2020
@DaveCTurner DaveCTurner deleted the 2020-01-02-fix-cat-nodes-local-param-docs branch January 2, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >docs General docs changes v7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants