-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the 'local' parameter of /_cat/nodes #50594
Remove the 'local' parameter of /_cat/nodes #50594
Conversation
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`. Today it accepts the `?local` parameter and passes this to the `ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`. This is surprising, because `GET _cat/nodes?local` looks like it might be a completely local call but in fact it still depends on every node in the cluster. This parameter was deprecated in 7.x in elastic#50499 and this commit removes it. Relates elastic#50088
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small questions about the tests :)
server/src/main/java/org/elasticsearch/rest/action/cat/RestNodesAction.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/rest/action/cat/RestNodesActionTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we get a compile error when we move to v9 and drop the v7 version constants.
Fair point, that's a good enough answer to the other question then as well :) => LGTM
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`. Today it accepts the `?local` parameter and passes this to the `ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`. This is surprising, because `GET _cat/nodes?local` looks like it might be a completely local call but in fact it still depends on every node in the cluster. This parameter was deprecated in 7.x in elastic#50499 and this commit removes it. Relates elastic#50088
The cat nodes API performs a
ClusterStateAction
then aNodesInfoAction
.Today it accepts the
?local
parameter and passes this to theClusterStateAction
but this parameter has no effect on theNodesInfoAction
.This is surprising, because
GET _cat/nodes?local
looks like it might be acompletely local call but in fact it still depends on every node in the
cluster.
This parameter was deprecated in 7.x in #50499 and this commit removes it.
Relates #50088