Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'local' parameter of /_cat/nodes #50594

Conversation

DaveCTurner
Copy link
Contributor

The cat nodes API performs a ClusterStateAction then a NodesInfoAction.
Today it accepts the ?local parameter and passes this to the
ClusterStateAction but this parameter has no effect on the NodesInfoAction.
This is surprising, because GET _cat/nodes?local looks like it might be a
completely local call but in fact it still depends on every node in the
cluster.

This parameter was deprecated in 7.x in #50499 and this commit removes it.

Relates #50088

The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`.
Today it accepts the `?local` parameter and passes this to the
`ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`.
This is surprising, because `GET _cat/nodes?local` looks like it might be a
completely local call but in fact it still depends on every node in the
cluster.

This parameter was deprecated in 7.x in elastic#50499 and this commit removes it.

Relates elastic#50088
@DaveCTurner DaveCTurner added >breaking :Core/Infra/Core Core issues without another label v8.0.0 labels Jan 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small questions about the tests :)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we get a compile error when we move to v9 and drop the v7 version constants.

Fair point, that's a good enough answer to the other question then as well :) => LGTM

@DaveCTurner DaveCTurner merged commit 8c6f821 into elastic:master Jan 6, 2020
@DaveCTurner DaveCTurner deleted the 2019-01-03-remove-cat-nodes-local-parameter branch January 6, 2020 14:12
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`.
Today it accepts the `?local` parameter and passes this to the
`ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`.
This is surprising, because `GET _cat/nodes?local` looks like it might be a
completely local call but in fact it still depends on every node in the
cluster.

This parameter was deprecated in 7.x in elastic#50499 and this commit removes it.

Relates elastic#50088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Core/Infra/Core Core issues without another label v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants