Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ILM poll_interval limit to breaking changes #41095

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Add ILM poll_interval limit to breaking changes #41095

merged 1 commit into from
Apr 12, 2019

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Apr 10, 2019

ILM's poll_interval setting now has a lower limit of 1 second, which is
technically a breaking change.

Follow-up to #39593
Relates to #39163

@gwbrown
Add ILM poll_interval limit to breaking changes
84991fc 
ILM's poll_interval setting now has a lower limit of 1 second, which is
technically a breaking change.
@gwbrown gwbrown added >docs General docs changes :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 labels Apr 10, 2019
@gwbrown gwbrown requested a review from dakrone April 10, 2019 22:53
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

jasontedor
jasontedor reviewed Apr 10, 2019
View reviewed changes
docs/reference/migration/migrate_8_0/ilm.asciidoc

//tag::notable-breaking-changes[]

// end::notable-breaking-changes[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That header was added to all of the subsection documents in #40990, I just added it to be in line with the rest of the documents in this directory.

I can remove it if it's not necessary but @lcawl may want to weigh in as she made the original changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this message from @lcawl, GitHub is giving her trouble posting comments but she said this:

If you want to have the option to tag content in this page and have it appear in https://www.elastic.co/guide/en/elastic-stack/master/elasticsearch-breaking-changes.html too, please do leave that empty tagged section (or put it around your poll interval section)

The poll interval thing definitely does not deserve to be marked as notable - I would be shocked if any real cluster had it set to less than 1 second - but we may have notable breaking changes to ILM sometime before 8.0 so I'm going to leave the empty tagged section there.

dakrone
dakrone approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM, pending question about the formatting

@lcawl lcawl mentioned this pull request Apr 11, 2019
Merged
@gwbrown gwbrown merged commit 454e496 into elastic:master Apr 12, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@gwbrown
Add ILM poll_interval limit to breaking changes (elastic#41095)
b6ebf24 
ILM's poll_interval setting now has a lower limit of 1 second, which is
technically a breaking change.
This was referenced Sep 14, 2021
Merged
Merged
jrodewig added a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733)
49494aa 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78084)
8b447cd 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78083)
52feb11 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78085)
0c6e26f 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78090)
3d8f98e 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78088)
0975c5b 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78086)
0a2bfaf 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78089)
72bc576 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78087)
a1e564a 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
jrodewig added a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78091)
f5a0b8d 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
jrodewig added a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78092)
749f498 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
jrodewig added a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78093)
f18fa37 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
jrodewig added a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78094)
1b4b12b 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
jrodewig added a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78095)
aac5777 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
jrodewig added a commit that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add deprecation docs for low ILM poll intervals (#77733) (#78097)
47aa001 
We deprecated ILM poll intervals of less than 1 second in 7.2 with PR #41096
However, we didn't add a related item to the 7.2 deprecation docs.
This adds the missing item.

Relates to #41095.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor left review comments

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gwbrown @elasticmachine @dakrone @jasontedor @jakelandis