Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ILM poll_interval limit to breaking changes #41095

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Add ILM poll_interval limit to breaking changes #41095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/reference/migration/migrate_8_0.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ coming[8.0.0]
* <<breaking_80_packaging_changes>>
* <<breaking_80_snapshots_changes>>
* <<breaking_80_security_changes>>
* <<breaking_80_ilm_changes>>
* <<breaking_80_java_changes>>

//NOTE: The notable-breaking-changes tagged regions are re-used in the
Expand Down Expand Up @@ -46,4 +47,5 @@ include::migrate_8_0/mappings.asciidoc[]
include::migrate_8_0/packaging.asciidoc[]
include::migrate_8_0/snapshots.asciidoc[]
include::migrate_8_0/security.asciidoc[]
include::migrate_8_0/ilm.asciidoc[]
include::migrate_8_0/java.asciidoc[]
17 changes: 17 additions & 0 deletions docs/reference/migration/migrate_8_0/ilm.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
[float]
[[breaking_80_ilm_changes]]
=== Index Lifecycle Management changes

//NOTE: The notable-breaking-changes tagged regions are re-used in the
//Installation and Upgrade Guide

//tag::notable-breaking-changes[]

// end::notable-breaking-changes[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That header was added to all of the subsection documents in #40990, I just added it to be in line with the rest of the documents in this directory.

I can remove it if it's not necessary but @lcawl may want to weigh in as she made the original changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this message from @lcawl, GitHub is giving her trouble posting comments but she said this:

If you want to have the option to tag content in this page and have it appear in https://www.elastic.co/guide/en/elastic-stack/master/elasticsearch-breaking-changes.html too, please do leave that empty tagged section (or put it around your poll interval section)

The poll interval thing definitely does not deserve to be marked as notable - I would be shocked if any real cluster had it set to less than 1 second - but we may have notable breaking changes to ILM sometime before 8.0 so I'm going to leave the empty tagged section there.


[float]
[[ilm-poll-interval-limit]]
==== `indices.lifecycle.poll_interval` must be greater than 1 second

The setting `indices.lifecycle.poll_interval`, if set too low, can cause
excessive load on a cluster. This setting must now be set to 1 second or higher.