Relax history check in ShardFollowTaskReplicationTests #39162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
|
Pinging @elastic/es-distributed |
|
@elasticmachine test this please |
|
Thanks @martijnvg. |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 20, 2019
* master: Mute failing CCR retention lease unfollow test Add support for ccr follow info api to HLRC. (elastic#39115) Do not create the missing index when invoking getRole (elastic#39039) Relax history check in ShardFollowTaskReplicationTests (elastic#39162) Add retention leases replication tests (elastic#38857) Edits to text in Phrase Suggester doc (elastic#38966) Edits to text in API Conventions docs (elastic#39001)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 20, 2019
* master: Mute failing CCR retention lease unfollow test Add support for ccr follow info api to HLRC. (elastic#39115) Do not create the missing index when invoking getRole (elastic#39039) Relax history check in ShardFollowTaskReplicationTests (elastic#39162) Add retention leases replication tests (elastic#38857) Edits to text in Phrase Suggester doc (elastic#38966) Edits to text in API Conventions docs (elastic#39001)
dnhatn
added a commit
that referenced
this pull request
Feb 21, 2019
The follower won't always have the same history as the leader for its soft-deletes retention can be different. However, if some operation exists on the history of the follower, then the same operation must exist on the leader. This change relaxes the history check in ShardFollowTaskReplicationTests. Closes #39093
dnhatn
added a commit
that referenced
this pull request
Feb 21, 2019
The follower won't always have the same history as the leader for its soft-deletes retention can be different. However, if some operation exists on the history of the follower, then the same operation must exist on the leader. This change relaxes the history check in ShardFollowTaskReplicationTests. Closes #39093
dnhatn
added a commit
that referenced
this pull request
Feb 21, 2019
The follower won't always have the same history as the leader for its soft-deletes retention can be different. However, if some operation exists on the history of the follower, then the same operation must exist on the leader. This change relaxes the history check in ShardFollowTaskReplicationTests. Closes #39093
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
The follower won't always have the same history as the leader for its soft-deletes retention can be different. However, if some operation exists on the history of the follower, then the same operation must exist on the leader. This change relaxes the history check in ShardFollowTaskReplicationTests. Closes elastic#39093
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
The follower won't always have the same history as the leader for its soft-deletes retention can be different. However, if some operation exists on the history of the follower, then the same operation must exist on the leader. This change relaxes the history check in ShardFollowTaskReplicationTests. Closes elastic#39093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follower won't always have the same history as the leader for its soft-deletes retention can be different. However, if some operation exists on the history of the follower, then the same operation must exist on the leader. This change relaxes the history check in ShardFollowTaskReplicationTests.
Closes #39093