Edits to text in Phrase Suggester doc #38966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmeiss
commented
Feb 15, 2019
| misspelled even if the term exists in the dictionary. The default is | ||
| `0.95` corresponding to 5% of the real words are misspelled. | ||
| `0.95`, meaning 5% of the real words are misspelled. |
There was a problem hiding this comment.
I was a bit unsure about the accuracy of this edit.
dmeiss
commented
Feb 15, 2019
| default is set to `1.0` which corresponds to that only corrections with | ||
| at most 1 misspelled term are returned. Note that setting this too high | ||
| can negatively impact performance. Low values like `1` or `2` are recommended | ||
| default is set to `1.0`, meaning only corrections with |
There was a problem hiding this comment.
I was a bit unsure about the accuracy of this edit.
ebadyano
added
>docs
|
Pinging @elastic/es-search |
|
@elasticmachine test this please |
1 similar comment
|
@elasticmachine test this please |
jimczi
approved these changes
Feb 19, 2019
| misspelled even if the term exists in the dictionary. The default is | ||
| `0.95` corresponding to 5% of the real words are misspelled. | ||
| `0.95`, meaning 5% of the real words are misspelled. |
| default is set to `1.0` which corresponds to that only corrections with | ||
| at most 1 misspelled term are returned. Note that setting this too high | ||
| can negatively impact performance. Low values like `1` or `2` are recommended | ||
| default is set to `1.0`, meaning only corrections with |
danielmitterdorfer
pushed a commit
that referenced
this pull request
Feb 20, 2019
danielmitterdorfer
pushed a commit
that referenced
this pull request
Feb 20, 2019
danielmitterdorfer
pushed a commit
that referenced
this pull request
Feb 20, 2019
danielmitterdorfer
pushed a commit
that referenced
this pull request
Feb 20, 2019
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 20, 2019
* master: Mute failing CCR retention lease unfollow test Add support for ccr follow info api to HLRC. (elastic#39115) Do not create the missing index when invoking getRole (elastic#39039) Relax history check in ShardFollowTaskReplicationTests (elastic#39162) Add retention leases replication tests (elastic#38857) Edits to text in Phrase Suggester doc (elastic#38966) Edits to text in API Conventions docs (elastic#39001)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 20, 2019
* master: Mute failing CCR retention lease unfollow test Add support for ccr follow info api to HLRC. (elastic#39115) Do not create the missing index when invoking getRole (elastic#39039) Relax history check in ShardFollowTaskReplicationTests (elastic#39162) Add retention leases replication tests (elastic#38857) Edits to text in Phrase Suggester doc (elastic#38966) Edits to text in API Conventions docs (elastic#39001)
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor text edits for phrasing, punctuation, and capitalization.