-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not create the missing index when invoking getRole #39039
Do not create the missing index when invoking getRole #39039
Conversation
Pinging @elastic/es-security |
For the PR bwc failure https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-bwc/232/consoleFull we don't have the nodes' logs . I presume this is on purpose, and I have raised a discussion over Slack about it, but I won't mute because it is very unlikely the limited failure log information would lead to a fix and unmute (it looks like a cluster state timeout with an unassigned shard). 🎲 @elasticmachine run elasticsearch-ci/bwc |
Aaaargh, the cast_die is tripping locale conversions... @elasticmachine run elasticsearch-ci/bwc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I actually think this is a bug and we should backport this to the 7.0 branch too
* master: Mute failing CCR retention lease unfollow test Add support for ccr follow info api to HLRC. (elastic#39115) Do not create the missing index when invoking getRole (elastic#39039) Relax history check in ShardFollowTaskReplicationTests (elastic#39162) Add retention leases replication tests (elastic#38857) Edits to text in Phrase Suggester doc (elastic#38966) Edits to text in API Conventions docs (elastic#39001)
* master: Mute failing CCR retention lease unfollow test Add support for ccr follow info api to HLRC. (elastic#39115) Do not create the missing index when invoking getRole (elastic#39039) Relax history check in ShardFollowTaskReplicationTests (elastic#39162) Add retention leases replication tests (elastic#38857) Edits to text in Phrase Suggester doc (elastic#38966) Edits to text in API Conventions docs (elastic#39001)
In most of the places we avoid creating the `.security` index (or updating the mapping) for read/search operations. This is more of a nit for the case of the getRole call, that fixes a possible mapping update during a get role, and removes a dead if branch about creating the `.security` index.
In most of the places we avoid creating the `.security` index (or updating the mapping) for read/search operations. This is more of a nit for the case of the getRole call, that fixes a possible mapping update during a get role, and removes a dead if branch about creating the `.security` index.
In most of the places we avoid creating the `.security` index (or updating the mapping) for read/search operations. This is more of a nit for the case of the getRole call, that fixes a possible mapping update during a get role, and removes a dead if branch about creating the `.security` index.
In most of the places we avoid creating the `.security` index (or updating the mapping) for read/search operations. This is more of a nit for the case of the getRole call, that fixes a possible mapping update during a get role, and removes a dead if branch about creating the `.security` index.
In most of the places we avoid creating the
.security
index (or updating the mapping) for read/search operations. This is more of a nit for the case of the getRole call, that fixes a possible mapping update during a get role, and removes a dead if branch about creating the.security
index.