Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create the missing index when invoking getRole #39039

Conversation

albertzaharovits
Copy link
Contributor

In most of the places we avoid creating the .security index (or updating the mapping) for read/search operations. This is more of a nit for the case of the getRole call, that fixes a possible mapping update during a get role, and removes a dead if branch about creating the .security index.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@albertzaharovits
Copy link
Contributor Author

albertzaharovits commented Feb 18, 2019

For the PR bwc failure https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-bwc/232/consoleFull we don't have the nodes' logs . I presume this is on purpose, and I have raised a discussion over Slack about it, but I won't mute because it is very unlikely the limited failure log information would lead to a fix and unmute (it looks like a cluster state timeout with an unassigned shard).

🎲 @elasticmachine run elasticsearch-ci/bwc

@albertzaharovits
Copy link
Contributor Author

albertzaharovits commented Feb 19, 2019

02:00:46 * What went wrong:
02:00:46 Could not set the value of environment variable 'ghprbCommentBody': could not convert string to current locale
02:00:46
02:00:46 * Try:
02:00:46 Run with --debug option to get more log output. Run with --scan to get full insights.
02:00:46
02:00:46 * Exception is:
02:00:46 net.rubygrapefruit.platform.NativeException: Could not set the value of environment variable 'ghprbCommentBody': could not convert string to current locale
02:00:46 at net.rubygrapefruit.platform.internal.DefaultProcess.setEnvironmentVariable(DefaultProcess.java:71)
02:00:46 at net.rubygrapefruit.platform.internal.WrapperProcess.setEnvironmentVariable(WrapperProcess.java:84)
02:00:46 at org.gradle.internal.nativeintegration.processenvironment.NativePlatformBackedProcessEnvironment.setNativeEnvironmentVariable(NativePlatformBackedProcessEnvironment.java:36)
02:00:46 at org.gradle.internal.nativeintegration.processenvironment.AbstractProcessEnvironment.setEnvironmentVariable(AbstractProcessEnvironment.java:67)
02:00:46 at

Aaaargh, the cast_die is tripping locale conversions...

@elasticmachine run elasticsearch-ci/bwc

Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I actually think this is a bug and we should backport this to the 7.0 branch too

@albertzaharovits albertzaharovits changed the title NIT: do not create the missing index when invoking getRole Do not create the missing index when invoking getRole Feb 20, 2019
@albertzaharovits albertzaharovits merged commit 85311c3 into elastic:master Feb 20, 2019
@albertzaharovits albertzaharovits deleted the index-read-does-not-create-index-get-role branch February 20, 2019 13:32
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 20, 2019
* master:
  Mute failing CCR retention lease unfollow test
  Add support for ccr follow info api to HLRC. (elastic#39115)
  Do not create the missing index when invoking getRole (elastic#39039)
  Relax history check in ShardFollowTaskReplicationTests (elastic#39162)
  Add retention leases replication tests (elastic#38857)
  Edits to text in Phrase Suggester doc (elastic#38966)
  Edits to text in API Conventions docs (elastic#39001)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 20, 2019
* master:
  Mute failing CCR retention lease unfollow test
  Add support for ccr follow info api to HLRC. (elastic#39115)
  Do not create the missing index when invoking getRole (elastic#39039)
  Relax history check in ShardFollowTaskReplicationTests (elastic#39162)
  Add retention leases replication tests (elastic#38857)
  Edits to text in Phrase Suggester doc (elastic#38966)
  Edits to text in API Conventions docs (elastic#39001)
albertzaharovits added a commit that referenced this pull request Feb 20, 2019
In most of the places we avoid creating the `.security` index (or updating the mapping)
for read/search operations. This is more of a nit for the case of the getRole call,
that fixes a possible mapping update during a get role, and removes a dead if branch
about creating the `.security` index.
albertzaharovits added a commit that referenced this pull request Feb 20, 2019
In most of the places we avoid creating the `.security` index (or updating the mapping)
for read/search operations. This is more of a nit for the case of the getRole call,
that fixes a possible mapping update during a get role, and removes a dead if branch
about creating the `.security` index.
weizijun pushed a commit to weizijun/elasticsearch that referenced this pull request Feb 22, 2019
In most of the places we avoid creating the `.security` index (or updating the mapping)
for read/search operations. This is more of a nit for the case of the getRole call,
that fixes a possible mapping update during a get role, and removes a dead if branch
about creating the `.security` index.
weizijun pushed a commit to weizijun/elasticsearch that referenced this pull request Feb 22, 2019
In most of the places we avoid creating the `.security` index (or updating the mapping)
for read/search operations. This is more of a nit for the case of the getRole call,
that fixes a possible mapping update during a get role, and removes a dead if branch
about creating the `.security` index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants