Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary platfromArchitectures from InferenceService tests #113890

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

dan-rubinstein
Copy link
Member

Fixing a java compilation failure caused by merging #113623. This was caused because another change was merged that removed some inputs to the parseRequestConfig method of inference services. This change removes these lines.

@dan-rubinstein dan-rubinstein added >bug :ml Machine learning Team:ML Meta label for the ML team labels Oct 1, 2024
@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v9.0.0 labels Oct 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@dan-rubinstein dan-rubinstein added v8.16.0 and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @dan-rubinstein, I've created a changelog YAML for you.

Copy link
Member

@maxhniebergall maxhniebergall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/changelog/113890.yaml Outdated Show resolved Hide resolved
@dan-rubinstein dan-rubinstein merged commit 276f71d into elastic:main Oct 1, 2024
16 checks passed
dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Oct 3, 2024
elastic#113890)

* Removing unnecessary platfromArchitectures from InferenceService tests

* Update docs/changelog/113890.yaml

* Delete docs/changelog/113890.yaml
matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 4, 2024
elastic#113890)

* Removing unnecessary platfromArchitectures from InferenceService tests

* Update docs/changelog/113890.yaml

* Delete docs/changelog/113890.yaml
maxhniebergall pushed a commit that referenced this pull request Oct 7, 2024
…ce, and HuggingFaceService (#113623) (#113886)

* Adding chunking settings to MistralService, GoogleAiStudioService, and HuggingFaceService (#113623)

* Adding chunking settings to MistralService, GoogleAiStudioService, and HuggingFaceService

* Update docs/changelog/113623.yaml

* Removing chunking settings from HuggingFaceElser model inputs

* Removing unnecessary platfromArchitectures from InferenceService tests (#113890)

* Removing unnecessary platfromArchitectures from InferenceService tests

* Update docs/changelog/113890.yaml

* Delete docs/changelog/113890.yaml

* Fix HuggingFaceMixedIT test sometimes failing when run on version before 8.16 (#114061)

* Fix HuggingFaceMixedIT test sometimes failing when run on version before 8.16

* Fixing typo in expected error message

---------

Co-authored-by: Elastic Machine <[email protected]>
@dan-rubinstein dan-rubinstein deleted the fix-chunking-pr-merge branch October 16, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants