-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing unnecessary platfromArchitectures from InferenceService tests #113890
Merged
dan-rubinstein
merged 3 commits into
elastic:main
from
dan-rubinstein:fix-chunking-pr-merge
Oct 1, 2024
Merged
Removing unnecessary platfromArchitectures from InferenceService tests #113890
dan-rubinstein
merged 3 commits into
elastic:main
from
dan-rubinstein:fix-chunking-pr-merge
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-rubinstein
added
>bug
:ml
Machine learning
Team:ML
Meta label for the ML team
labels
Oct 1, 2024
elasticsearchmachine
added
external-contributor
Pull request authored by a developer outside the Elasticsearch team
v9.0.0
labels
Oct 1, 2024
Pinging @elastic/ml-core (Team:ML) |
dan-rubinstein
added
v8.16.0
and removed
external-contributor
Pull request authored by a developer outside the Elasticsearch team
labels
Oct 1, 2024
Hi @dan-rubinstein, I've created a changelog YAML for you. |
maxhniebergall
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dan-rubinstein
added a commit
to dan-rubinstein/elasticsearch
that referenced
this pull request
Oct 3, 2024
elastic#113890) * Removing unnecessary platfromArchitectures from InferenceService tests * Update docs/changelog/113890.yaml * Delete docs/changelog/113890.yaml
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
elastic#113890) * Removing unnecessary platfromArchitectures from InferenceService tests * Update docs/changelog/113890.yaml * Delete docs/changelog/113890.yaml
maxhniebergall
pushed a commit
that referenced
this pull request
Oct 7, 2024
…ce, and HuggingFaceService (#113623) (#113886) * Adding chunking settings to MistralService, GoogleAiStudioService, and HuggingFaceService (#113623) * Adding chunking settings to MistralService, GoogleAiStudioService, and HuggingFaceService * Update docs/changelog/113623.yaml * Removing chunking settings from HuggingFaceElser model inputs * Removing unnecessary platfromArchitectures from InferenceService tests (#113890) * Removing unnecessary platfromArchitectures from InferenceService tests * Update docs/changelog/113890.yaml * Delete docs/changelog/113890.yaml * Fix HuggingFaceMixedIT test sometimes failing when run on version before 8.16 (#114061) * Fix HuggingFaceMixedIT test sometimes failing when run on version before 8.16 * Fixing typo in expected error message --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a java compilation failure caused by merging #113623. This was caused because another change was merged that removed some inputs to the parseRequestConfig method of inference services. This change removes these lines.