Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Adding chunking settings to MistralService, GoogleAiStudioService, and HuggingFaceService (#113623) #113886

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

dan-rubinstein
Copy link
Member

@dan-rubinstein dan-rubinstein commented Oct 1, 2024

Backports the following commits to 8.x:

…d HuggingFaceService (elastic#113623)

* Adding chunking settings to MistralService, GoogleAiStudioService, and HuggingFaceService

* Update docs/changelog/113623.yaml

* Removing chunking settings from HuggingFaceElser model inputs
@dan-rubinstein dan-rubinstein added :ml Machine learning >enhancement auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:ML Meta label for the ML team labels Oct 1, 2024
@elasticsearchmachine elasticsearchmachine added v8.16.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 1, 2024
@dan-rubinstein dan-rubinstein removed the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 1, 2024
elastic#113890)

* Removing unnecessary platfromArchitectures from InferenceService tests

* Update docs/changelog/113890.yaml

* Delete docs/changelog/113890.yaml
@dan-rubinstein
Copy link
Member Author

@elasticmachine merge upstream

@dan-rubinstein
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Member

@maxhniebergall maxhniebergall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxhniebergall maxhniebergall removed the external-contributor Pull request authored by a developer outside the Elasticsearch team label Oct 3, 2024
@dan-rubinstein
Copy link
Member Author

@elasticmachine merge upstream

elasticmachine and others added 2 commits October 7, 2024 15:40
…ore 8.16 (elastic#114061)

* Fix HuggingFaceMixedIT test sometimes failing when run on version before 8.16

* Fixing typo in expected error message
@dan-rubinstein
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Member

@maxhniebergall maxhniebergall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxhniebergall maxhniebergall merged commit 183aa71 into elastic:8.x Oct 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >enhancement :ml Machine learning Team:ML Meta label for the ML team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants