[otel-plugin] Add aliases for spanevent/logrecord exceptions #113636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.0.0
external-contributor
lahsivjar
reviewed
Sep 27, 2024
...lugin/otel-data/src/main/resources/component-templates/[email protected]
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
gregkalapos
changed the title
gregkalapos
commented
Oct 1, 2024
...ugin/otel-data/src/main/resources/component-templates/[email protected]
Outdated
Show resolved
Hide resolved
elasticsearchmachine
added
the
needs:triage
gregkalapos
commented
Oct 1, 2024
| error.exception.message: | ||
| type: alias | ||
| path: attributes.exception.message | ||
|
|
There was a problem hiding this comment.
No alias for handled, because we send it as error.exceptin.handled (by inverting exception.escaped and attaching it in the enrichment lib) - and that works via passthrough.
Just raising it here to double-check: that's ok, right?
gregkalapos
added
the
:Data Management/Data streams
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
gregkalapos
commented
Oct 1, 2024
...ugin/otel-data/src/main/resources/component-templates/[email protected]
Outdated
Show resolved
Hide resolved
felixbarny
reviewed
Oct 1, 2024
...ugin/otel-data/src/main/resources/component-templates/[email protected]
Outdated
Show resolved
Hide resolved
lahsivjar
approved these changes
Oct 1, 2024
|
@elasticmachine update branch |
To be on the safe side, I increased it. |
|
I think the failing test is being fixed in #113890. |
|
@elasticmachine update branch |
felixbarny
approved these changes
Oct 2, 2024
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gregkalapos
added a commit
to gregkalapos/elasticsearch
that referenced
this pull request
Oct 2, 2024
…#113636) * Add tests for exceptions * Adapt aliases and move into a separate file * Clarify description in alias files * Handling stacktrace * Move error aliases to [email protected] * Update resources.yaml --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit af7c81e) # Conflicts: # x-pack/plugin/otel-data/src/main/resources/resources.yaml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 3, 2024
#113925) * Add tests for exceptions * Adapt aliases and move into a separate file * Clarify description in alias files * Handling stacktrace * Move error aliases to [email protected] * Update resources.yaml --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit af7c81e) # Conflicts: # x-pack/plugin/otel-data/src/main/resources/resources.yaml Co-authored-by: Felix Barnsteiner <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
…#113636) * Add tests for exceptions * Adapt aliases and move into a separate file * Clarify description in alias files * Handling stacktrace * Move error aliases to [email protected] * Update resources.yaml --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding aliases for exception fields.