Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "x-pack/plugin/core: make automatic rollovers lazy" #104734

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Revert "x-pack/plugin/core: make automatic rollovers lazy" #104734

merged 3 commits into from
Jan 26, 2024

Conversation

axw
Copy link
Member

@axw axw commented Jan 25, 2024

Reverts #104597

Reverting due to #104732, will reinstate it when the bug is fixed.

@axw axw added >bug :Data Management/Data streams Data streams and their lifecycles labels Jan 25, 2024
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team v8.13.0 labels Jan 25, 2024
@elasticsearchmachine
Copy link
Collaborator

@axw please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jan 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @axw, I've created a changelog YAML for you.

@axw axw requested a review from gmarouli January 25, 2024 09:17
@axw axw added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 25, 2024
gmarouli
gmarouli approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@gmarouli gmarouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for reverting it until we fix the permission discrepancy.

@gmarouli gmarouli added >non-issue and removed >bug labels Jan 26, 2024
@gmarouli
Copy link
Contributor

I made one change on the label. Since this was reverted before it was released I wanted to remove the change log so I marked it as a non-issue. Let me know if you agree.

@elasticsearchmachine elasticsearchmachine merged commit 807147d into main Jan 26, 2024
16 checks passed
@elasticsearchmachine elasticsearchmachine deleted the revert-104597-registry-rollover-lazy branch January 26, 2024 08:51
@axw
Copy link
Member Author

axw commented Jan 28, 2024

I made one change on the label. Since this was reverted before it was released I wanted to remove the change log so I marked it as a non-issue. Let me know if you agree.

Thanks, I'll do that in future - I just wasn't familiar with the process.

gmarouli added a commit to gmarouli/elasticsearch that referenced this pull request Jan 31, 2024
@gmarouli
Revert "Revert "x-pack/plugin/core: make automatic rollovers lazy" (e…
ac14813 
…lastic#104734)"

This reverts commit 807147d.
gmarouli added a commit to gmarouli/elasticsearch that referenced this pull request Jan 31, 2024
@gmarouli
Revert "Revert "Revert "x-pack/plugin/core: make automatic rollovers …
8bbe6c9 
…lazy" (elastic#104734)""

This reverts commit ac14813.
axw added a commit that referenced this pull request Feb 8, 2024
@axw
Revert "Revert "x-pack/plugin/core: make automatic rollovers lazy" (#…
bdfeab7 
…104734)"

This reverts commit 807147d.
@axw axw mentioned this pull request Feb 8, 2024
Merged
elasticsearchmachine pushed a commit that referenced this pull request Feb 9, 2024
@axw
Revert "Revert "x-pack/plugin/core: make automatic rollovers lazy"" (#…
071dd31 
…105273)

Reverts #104734.
#104732 has been fixed,
so it's safe to use lazy rollovers now.

Fixes #104083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarouli gmarouli gmarouli approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Data streams Data streams and their lifecycles external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Data Management Meta label for data/management team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axw @elasticsearchmachine @gmarouli