Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "x-pack/plugin/core: make automatic rollovers lazy"" #105273

Merged

Conversation

axw
Copy link
Member

@axw axw commented Feb 8, 2024

Reverts #104734. #104732 has been fixed, so it's safe to use lazy rollovers now.

Fixes #104083

@axw axw added >enhancement :Data Management/Data streams Data streams and their lifecycles labels Feb 8, 2024
@axw axw requested a review from gmarouli February 8, 2024 07:58
@elasticsearchmachine
Copy link
Collaborator

@axw please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v8.13.0 Team:Data Management Meta label for data/management team external-contributor Pull request authored by a developer outside the Elasticsearch team labels Feb 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @axw, I've created a changelog YAML for you.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axw
Copy link
Member Author

axw commented Feb 8, 2024

@elasticmachine update branch

@axw axw added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Feb 8, 2024
@axw
Copy link
Member Author

axw commented Feb 9, 2024

/run elasticsearch-ci/packaging-tests-windows-sample

@axw
Copy link
Member Author

axw commented Feb 9, 2024

/run elasticsearch-ci/windows-2019 / default-windows-archive / packaging-tests-windows-sample

@axw
Copy link
Member Author

axw commented Feb 9, 2024

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit 071dd31 into main Feb 9, 2024
15 checks passed
@elasticsearchmachine elasticsearchmachine deleted the revert-104734-revert-104597-registry-rollover-lazy branch February 9, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Data streams Data streams and their lifecycles >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update internal unconditional rollover calls to use lazy rollover
4 participants