Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/plugin/core: make automatic rollovers lazy #104597

Merged
merged 7 commits into from
Jan 23, 2024
Merged

x-pack/plugin/core: make automatic rollovers lazy #104597

merged 7 commits into from
Jan 23, 2024

Conversation

axw
Copy link
Member

@axw axw commented Jan 22, 2024 •
edited
Loading

Apply automatic rollovers lazily, upon the next write, to avoid unnecessary empty backing indices.

See #89346

Fixes #104083

@axw
x-pack/plugin/core: make automatic rollovers lazy
0678f08 
Apply automatic rollovers lazily, upon the next write,
to avoid unnecessary empty backing indices.
See elastic#89346
@axw axw added >enhancement :Data Management/Data streams Data streams and their lifecycles v8.13.0 labels Jan 22, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @axw, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jan 22, 2024
@axw axw marked this pull request as draft January 22, 2024 04:27
@axw
Copy link
Member Author

axw commented Jan 22, 2024

Failure is in ESQL, unrelated to my changes AFAICS.

@axw axw marked this pull request as ready for review January 22, 2024 06:05
@felixbarny felixbarny requested a review from gmarouli January 22, 2024 07:33
@felixbarny
Copy link
Member

@elasticmachine run elasticsearch-ci/part-3

@axw
Copy link
Member Author

axw commented Jan 23, 2024

@elasticmachine update branch

gmarouli
gmarouli approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@gmarouli gmarouli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @axw. LGTM, if I am not mistaken this is fixing #104083.

@elasticsearchmachine
Copy link
Collaborator

Hi @axw, I've updated the changelog YAML for you.

@axw
Copy link
Member Author

axw commented Jan 23, 2024

Thank you for fixing this @axw. LGTM, if I am not mistaken this is fixing #104083.

Hah, I didn't see that issue before :) It does indeed. There's just one registry (the APM one) that overrides applyRolloverAfterTemplateV2Upgrade and enables auto rollover, and that's desirable for us.

@axw axw added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 23, 2024
@axw
Copy link
Member Author

axw commented Jan 23, 2024

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit 9e074b8 into elastic:main Jan 23, 2024
15 checks passed
@axw axw deleted the registry-rollover-lazy branch January 23, 2024 08:38
@axw axw mentioned this pull request Jan 25, 2024
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jan 26, 2024
@axw
Revert "x-pack/plugin/core: make automatic rollovers lazy" (#104734)
807147d 
Reverts #104597

Reverting due to #104732,
will reinstate it when the bug is fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone left review comments

@gmarouli gmarouli gmarouli approved these changes

@felixbarny felixbarny felixbarny approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Data streams Data streams and their lifecycles >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update internal unconditional rollover calls to use lazy rollover
6 participants
@axw @elasticsearchmachine @felixbarny @dakrone @gmarouli @elasticmachine