Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: the invalid url error message should be in line with the documentation #56476

Closed
astefan opened this issue May 8, 2020 · 2 comments · Fixed by #56612
Closed

SQL: the invalid url error message should be in line with the documentation #56476

astefan opened this issue May 8, 2020 · 2 comments · Fixed by #56612
Assignees
@matriv
Labels
:Analytics/SQL SQL querying >bug Team:QL (Deprecated) Meta label for query languages team

Comments

@astefan
Copy link
Contributor

astefan commented May 8, 2020

We state in docs that the url format should be jdbc:es://[[http|https]://]*[host[:port]]*/[prefix]*<[?[option=value]&]* but if the url is indeed incorrect, the error message mentions Invalid URL [jdbc:es://localhost:9200/?ssl=#5#], format should be [jdbc:es://[http|https]?[host[:port]]*/[prefix]*[?[option=value]&]*] which is inaccurate.
@astefan astefan added >bug :Analytics/SQL SQL querying labels May 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/SQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label May 8, 2020
@matriv matriv self-assigned this May 10, 2020
matriv added a commit to matriv/elasticsearch that referenced this issue May 12, 2020
@matriv
SQL: Fix JDBC url pattern in docs and error message
470608e 
The docs pattern url was using `*` which means zero or many instead
of `?` which means zero or one. The pattern url returned in error
messages was not in sync with the one in the docs.

Fixes: elastic#56476
@matriv matriv mentioned this issue May 12, 2020
Merged
matriv added a commit that referenced this issue May 13, 2020
@matriv
SQL: Fix JDBC url pattern in docs and error message (#56612)
1a5945c 
The docs pattern url was using `*` which means zero or many instead
of `?` which means zero or one. The pattern url returned in error
messages was not in sync with the one in the docs.

Fixes: #56476
matriv added a commit that referenced this issue May 13, 2020
@matriv
SQL: Fix JDBC url pattern in docs and error message (#56612)
e781193 
The docs pattern url was using `*` which means zero or many instead
of `?` which means zero or one. The pattern url returned in error
messages was not in sync with the one in the docs.

Fixes: #56476
(cherry picked from commit 1a5945c)
matriv added a commit that referenced this issue May 13, 2020
@matriv
SQL: Fix JDBC url pattern in docs and error message (#56612)
10aefc7 
The docs pattern url was using `*` which means zero or many instead
of `?` which means zero or one. The pattern url returned in error
messages was not in sync with the one in the docs.

Fixes: #56476
(cherry picked from commit 1a5945c)
matriv added a commit that referenced this issue May 13, 2020
@matriv
SQL: Fix JDBC url pattern in docs and error message (#56612)
3d4eec4 
The docs pattern url was using `*` which means zero or many instead
of `?` which means zero or one. The pattern url returned in error
messages was not in sync with the one in the docs.

Fixes: #56476
(cherry picked from commit 1a5945c)
@matriv
Copy link
Contributor

matriv commented May 13, 2020

master : 1a5945c
7.x : e781193
7.8 : 10aefc7
7.7 : 3d4eec4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matriv matriv

Labels
:Analytics/SQL SQL querying >bug Team:QL (Deprecated) Meta label for query languages team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Fix JDBC url pattern in docs and error message matriv/elasticsearch
3 participants
@astefan @matriv @elasticmachine