SQL: Fix JDBC url pattern in docs and error message #56612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs pattern url was using `*` which means zero or many instead of `?` which means zero or one. The pattern url returned in error messages was not in sync with the one in the docs. Fixes: elastic#56476
|
Pinging @elastic/es-ql (:Query Languages/SQL) |
elasticmachine
added
the
Team:QL (Deprecated)
matriv
commented
May 12, 2020
| @@ -51,7 +51,7 @@ Once registered, the driver understands the following syntax as an URL: | |||
|
|
|||
| ["source","text",subs="attributes"] | |||
| ---- | |||
| jdbc:es://[[http|https]://]*[host[:port]]*/[prefix]*<[?[option=value]&]* | |||
| jdbc:es://[[http|https]://]?[host[:port]]?/[prefix]?[?[option=value]&]* | |||
There was a problem hiding this comment.
? means zero ore one in regex, which is what we want, but how can we differentiate from the [?[option...] which is the actual char ? ? In the error message I used \?, but not sure. Any suggestions?
There was a problem hiding this comment.
For 0 or 1 (or ?) there is also the {0,1} more explicit notation, but I am not sure if we want to complicate things...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs pattern url was using
*which means zero or many insteadof
?which means zero or one. The pattern url returned in errormessages was not in sync with the one in the docs.
Fixes: #56476