Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReindexFailureTests fails with in-flight search context #47048

Closed
dnhatn opened this issue Sep 24, 2019 · 2 comments · Fixed by #47139
Closed

ReindexFailureTests fails with in-flight search context #47048

dnhatn opened this issue Sep 24, 2019 · 2 comments · Fixed by #47139
Assignees
@henningandersen
Labels
:Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down >test-failure Triaged test failures from CI

Comments

@dnhatn
Copy link
Member

dnhatn commented Sep 24, 2019

ReindexFailureTests suite fails quite often today (see the stats). I could not reproduce this locally.

java.lang.AssertionError: There are still [1] in-flight contexts. The first one's creation site is listed as the cause of this exception.
	at org.elasticsearch.search.MockSearchService.assertNoInFlightContext(MockSearchService.java:51)
	at org.elasticsearch.test.ESTestCase.lambda$ensureAllSearchContextsReleased$6(ESTestCase.java:507)
	at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:866)
	at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:840)
	at org.elasticsearch.test.ESTestCase.ensureAllSearchContextsReleased(ESTestCase.java:507)
	at org.elasticsearch.test.ESIntegTestCase.cleanUpCluster(ESIntegTestCase.java:1967)

Some instances:
@dnhatn dnhatn added >test-failure Triaged test failures from CI :Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down labels Sep 24, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@dnhatn dnhatn mentioned this issue Sep 24, 2019
Merged
@henningandersen
Copy link
Contributor

We could be facing this race condition:

https://github.com/elastic/elasticsearch/pull/46060/files#diff-ea35f804425b3f692e93dfef2ea1d1a5R78

though I did not look deeply into this yet.

@henningandersen henningandersen self-assigned this Sep 24, 2019
henningandersen added a commit to henningandersen/elasticsearch that referenced this issue Sep 25, 2019
@henningandersen
MockSearchService concurrency fix
035670a 
Fixed MockSearchService concurrency, assertNoInFlightContext could
have false negative result (rarely).

Split out from elastic#45739
Closes elastic#47048
@henningandersen henningandersen mentioned this issue Sep 25, 2019
Merged
henningandersen added a commit that referenced this issue Oct 2, 2019
@henningandersen
MockSearchService concurrency fix (#47139)
876594f 
Fixed MockSearchService concurrency, assertNoInFlightContext could
have false negative result (rarely).

Split out from #46060
Closes #47048
henningandersen added a commit that referenced this issue Oct 2, 2019
@henningandersen
MockSearchService concurrency fix (#47139)
b5a2afc 
Fixed MockSearchService concurrency, assertNoInFlightContext could
have false negative result (rarely).

Split out from #46060
Closes #47048
henningandersen added a commit that referenced this issue Oct 2, 2019
@henningandersen
MockSearchService concurrency fix (#47139)
8117f8a 
Fixed MockSearchService concurrency, assertNoInFlightContext could
have false negative result (rarely).

Split out from #46060
Closes #47048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henningandersen henningandersen

Labels
:Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MockSearchService concurrency fix henningandersen/elasticsearch
3 participants
@dnhatn @elasticmachine @henningandersen