-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search with failing nodes test #46060
Closed
henningandersen
wants to merge
4
commits into
elastic:main
from
henningandersen:test_search_with_failing_nodes
Closed
Search with failing nodes test #46060
henningandersen
wants to merge
4
commits into
elastic:main
from
henningandersen:test_search_with_failing_nodes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test case that verifies that searches running while nodes are failing behave correctly, in particular with allow_partial_search_results=false. Fixed MockSearchService concurrency, assertNoInFlightContext could have false negative result (rarely). Split out from elastic#45739
henningandersen
added
>test
Issues or PRs that are addressing/adding tests
:Search/Search
Search-related issues that do not fall into other categories
v8.0.0
v7.4.0
labels
Aug 28, 2019
Pinging @elastic/es-search |
ci/1 failed due to new issue, reported and fixed here #46064 |
henningandersen
added a commit
that referenced
this pull request
Oct 2, 2019
henningandersen
added a commit
that referenced
this pull request
Oct 2, 2019
henningandersen
added a commit
that referenced
this pull request
Oct 2, 2019
@elasticmachine update branch |
@elasticmachine update branch |
Pinging @elastic/es-search (Team:Search) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Search/Search
Search-related issues that do not fall into other categories
Team:Search
Meta label for search team
>test
Issues or PRs that are addressing/adding tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test case that verifies that searches running while nodes are
failing behave correctly, in particular with
allow_partial_search_results=false.
Fixed MockSearchService concurrency, assertNoInFlightContext could
have false negative result (rarely).
Split out from #45739