Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ensureIndexHasHistoryUUID method from Store #47043

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Remove ensureIndexHasHistoryUUID method from Store #47043

merged 1 commit into from
Sep 24, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 24, 2019

We no longer use this method in production code.

@dnhatn dnhatn added >non-issue :Distributed Indexing/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. v8.0.0 v7.5.0 labels Sep 24, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

henningandersen
henningandersen approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The test failure looks interesting (though hopefully unrelated).

@dnhatn
Copy link
Member Author

dnhatn commented Sep 24, 2019

I opened #47048 for the test failures.
@elasticmachine run elasticsearch-ci/1

@dnhatn
Copy link
Member Author

dnhatn commented Sep 24, 2019

Thanks @henningandersen.

@dnhatn dnhatn merged commit b269a77 into elastic:master Sep 24, 2019
@dnhatn dnhatn deleted the remove-ensure-history-uuid branch September 24, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningandersen henningandersen henningandersen approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. >non-issue v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnhatn @elasticmachine @henningandersen @jakelandis