fix(axis): ordinal number ending fix for the weekly resolution #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
approved these changes
Mar 28, 2022
packages/charts/src/chart_types/xy_chart/axes/timeslip/rasters.ts
Outdated
Show resolved
Hide resolved
nickofthyme
approved these changes
Mar 28, 2022
nickofthyme
reviewed
Mar 28, 2022
nickofthyme
pushed a commit
that referenced
this pull request
Mar 29, 2022
# [45.1.0](v45.0.1...v45.1.0) (2022-03-29) ### Bug Fixes * **axis:** ordinal number ending fix for the weekly resolution ([#1634](#1634)) ([18b4077](18b4077)) * **deps:** update dependency @elastic/eui to ^52.2.0 ([#1632](#1632)) ([7e0be07](7e0be07)) * **deps:** update dependency @elastic/eui to v50 ([#1622](#1622)) ([0eb7975](0eb7975)) * **deps:** update dependency @elastic/eui to v51 ([#1624](#1624)) ([64d87e5](64d87e5)) * **deps:** update dependency @elastic/eui to v52 ([#1630](#1630)) ([ada254e](ada254e)) * **goal:** chart placement and overlap issues ([#1620](#1620)) ([b5d375b](b5d375b)) ### Features * **goal:** expose max sizing limits in theme.goal options ([#1621](#1621)) ([60a14ba](60a14ba))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Besides fixing the weeklies, the following improvements are made:
stndrdthgot generalized to arbitrary integers (ie. beyond 31, and negatives too) for future reuseDetails
HT @markov00 for reporting this issue before integration 🙇 — I fixed it for the days but not for the weeks.
Issues
Fix #1633
Addresses elastic/kibana#128504
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)