-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tooltip): anchored/fixed position #1122
feat(tooltip): anchored/fixed position #1122
Conversation
d391b43
to
be1a8b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
- Coverage 72.26% 72.25% -0.02%
==========================================
Files 387 404 +17
Lines 12021 11582 -439
Branches 2629 2363 -266
==========================================
- Hits 8687 8368 -319
+ Misses 3309 3091 -218
- Partials 25 123 +98
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested locally and works great.
One thing that may be confusing is that the offset
is relative to the placement and not stickTo
. So if stickTo = 'top'
and placement = 'rightStart'
with offset = 50
you get this...
Where there is no offset from the top. I think this is the correct way of doing it but people might get confused.
…rkov00/elastic-charts into 2021_04_15-tooltip_fixd_on_top/bottom
@nickofthyme you are right, probably we should prefix the offset prop with something like |
# [29.1.0](v29.0.0...v29.1.0) (2021-04-23) ### Bug Fixes * **interaction:** remove unnecessary elements ([#1131](#1131)) ([411042f](411042f)), closes [#1074](#1074) * **partition:** fix safari highlight bug on single slice ([#1132](#1132)) ([4a04063](4a04063)), closes [#1085](#1085) ### Features * **tooltip:** add stickTo option ([#1122](#1122)) ([12417e2](12417e2)), closes [#921](#921)
🎉 This PR is included in version 29.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [29.1.0](elastic/elastic-charts@v29.0.0...v29.1.0) (2021-04-23) ### Bug Fixes * **interaction:** remove unnecessary elements ([opensearch-project#1131](elastic/elastic-charts#1131)) ([dde7bdb](elastic/elastic-charts@dde7bdb)), closes [opensearch-project#1074](elastic/elastic-charts#1074) * **partition:** fix safari highlight bug on single slice ([opensearch-project#1132](elastic/elastic-charts#1132)) ([729c179](elastic/elastic-charts@729c179)), closes [opensearch-project#1085](elastic/elastic-charts#1085) ### Features * **tooltip:** add stickTo option ([opensearch-project#1122](elastic/elastic-charts#1122)) ([534f2a3](elastic/elastic-charts@534f2a3)), closes [opensearch-project#921](elastic/elastic-charts#921)
Summary
Adding the prop
stickTo
to the tooltip settings to specify where to stick the tooltip respective to the cursor.Apr-15-2021.17-26-32.mp4
fix #921
Checklist
Delete any items that are not applicable to this PR.
src/index.ts
(and stories only import from../src
except for test data & storybook)