Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single slice pie chart rendering issue in Safari #1085

Closed
1 task done
markov00 opened this issue Mar 23, 2021 · 2 comments · Fixed by #1132
Closed
1 task done

Single slice pie chart rendering issue in Safari #1085

markov00 opened this issue Mar 23, 2021 · 2 comments · Fixed by #1132
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart :Lens Kibana Lens related issue :partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Mar 23, 2021

Describe the bug
In Safari, when a single slice pie chart has hovered, the highlighter renders an white cross artefact, probably caused by the SVG configuration of that specific Circle highlight.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://elastic.github.io/elastic-charts/?path=/story/sunburst--single-slice with Safari
  2. See the white cross on hover

Expected behaviour
A clear circle with the right fill color

Screenshots
Screenshot 2021-03-23 at 11 31 42

Version (please complete the following information):

  • Browser: Safari
  • Elastic Charts: master

Additional context
The highlighter is built as:

return <circle key={key} r={(y0px + y1px) / 2} {...props} fill="none" strokeWidth={y1px - y0px} />;

we can probably fix by using the fill color and fixing the radius to the correct one.

Errors in browser console
N/A

Kibana Cross Issues

@markov00 markov00 added bug Something isn't working kibana cross issue Has a Kibana issue counterpart :partition Partition/PieChart/Donut/Sunburst/Treemap chart related :Lens Kibana Lens related issue labels Mar 23, 2021
@markov00
Copy link
Member Author

markov00 commented Mar 23, 2021

Taking a look at the code, the PR that introduced the highlight was: #616
And the code introduced with this commit: a7d9e61
I don't see any special reference on why the circle was coded like that

markov00 added a commit to markov00/elastic-charts that referenced this issue Apr 22, 2021
markov00 added a commit that referenced this issue Apr 23, 2021
nickofthyme pushed a commit that referenced this issue Apr 23, 2021
# [29.1.0](v29.0.0...v29.1.0) (2021-04-23)

### Bug Fixes

* **interaction:** remove unnecessary elements ([#1131](#1131)) ([411042f](411042f)), closes [#1074](#1074)
* **partition:**  fix safari highlight bug on single slice ([#1132](#1132)) ([4a04063](4a04063)), closes [#1085](#1085)

### Features

* **tooltip:** add stickTo option ([#1122](#1122)) ([12417e2](12417e2)), closes [#921](#921)
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 29.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Apr 23, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart :Lens Kibana Lens related issue :partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants