Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: fixed position instead of following mouse and improved line indicator #921

Closed
1 of 2 tasks
Tracked by #615
sorenlouv opened this issue Nov 25, 2020 · 2 comments · Fixed by #1122
Closed
1 of 2 tasks
Tracked by #615

Tooltip: fixed position instead of following mouse and improved line indicator #921

sorenlouv opened this issue Nov 25, 2020 · 2 comments · Fixed by #1122
Assignees
@markov00
Labels
enhancement New feature or request released Issue released publicly :tooltip Related to hover tooltip

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Nov 25, 2020 •
edited by markov00
Loading

APM is in the process of migrating from react-vis to Elastic Charts, and while Elastic Charts is getting a lot of things right, I think two small changes could improve the UX:

  • The tooltip should be fixed on the y-axis and only move along along the x-axis. Having it move in both direction is distracting and doesn't add anything
  • As a user I expect to see the point on the line highlighted as I move long the x-axis. Unless it hit the exact spot wrt to both the y-axis and x-axis where the line is, it is not highlighted.

Old charts (react-vis)
apm-old-charts

New charts (Elastic Charts)
new-charts
@sorenlouv sorenlouv added the enhancement New feature or request label Nov 25, 2020
@nickofthyme nickofthyme added the :tooltip Related to hover tooltip label Nov 25, 2020
@markov00 markov00 mentioned this issue Dec 2, 2020
Open
18 tasks
@markov00 markov00 self-assigned this Apr 15, 2021
@markov00 markov00 mentioned this issue Apr 15, 2021
Merged
3 tasks
markov00 added a commit that referenced this issue Apr 23, 2021
@markov00
feat(tooltip): add stickTo option (#1122)
12417e2 
fix #921
nickofthyme pushed a commit that referenced this issue Apr 23, 2021
@semantic-release-bot
chore(release): 29.1.0 [skip ci]
21ecc5f 
# [29.1.0](v29.0.0...v29.1.0) (2021-04-23)

### Bug Fixes

* **interaction:** remove unnecessary elements ([#1131](#1131)) ([411042f](411042f)), closes [#1074](#1074)
* **partition:**  fix safari highlight bug on single slice ([#1132](#1132)) ([4a04063](4a04063)), closes [#1085](#1085)

### Features

* **tooltip:** add stickTo option ([#1122](#1122)) ([12417e2](12417e2)), closes [#921](#921)
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 29.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Apr 23, 2021
@formgeist formgeist mentioned this issue Apr 26, 2021
Closed
@formgeist
Copy link

Opened elastic/kibana#98282 to track APM's adoption of this new enhancement 🎉

@markov00 markov00 mentioned this issue May 25, 2021
Merged
3 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 29.1.0 [skip ci]
cd3f768 
# [29.1.0](elastic/elastic-charts@v29.0.0...v29.1.0) (2021-04-23)

### Bug Fixes

* **interaction:** remove unnecessary elements ([opensearch-project#1131](elastic/elastic-charts#1131)) ([dde7bdb](elastic/elastic-charts@dde7bdb)), closes [opensearch-project#1074](elastic/elastic-charts#1074)
* **partition:**  fix safari highlight bug on single slice ([opensearch-project#1132](elastic/elastic-charts#1132)) ([729c179](elastic/elastic-charts@729c179)), closes [opensearch-project#1085](elastic/elastic-charts#1085)

### Features

* **tooltip:** add stickTo option ([opensearch-project#1122](elastic/elastic-charts#1122)) ([534f2a3](elastic/elastic-charts@534f2a3)), closes [opensearch-project#921](elastic/elastic-charts#921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
enhancement New feature or request released Issue released publicly :tooltip Related to hover tooltip
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(tooltip): anchored/fixed position markov00/elastic-charts
4 participants
@sorenlouv @markov00 @formgeist @nickofthyme