Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brush canvas is not aligned with the rendering canvas in codesandbox #620

Closed
markov00 opened this issue Apr 6, 2020 · 1 comment
Closed

Brush canvas is not aligned with the rendering canvas in codesandbox #620

markov00 opened this issue Apr 6, 2020 · 1 comment
Labels
bug Something isn't working :interactions Interactions related issue released Issue released publicly :styling Styling related issue

Comments

@markov00
Copy link
Member

markov00 commented Apr 6, 2020 •
edited
Loading

Describe the bug
Brush canvas is not aligned with the rendering canvas in codesandbox

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/naughty-jennings-pyhpn
  2. Drag to use the brushtool
  3. The brush will start at a wrong position

Expected behaviour
The brush canvas should overlay exactly the rendering canvsa

Screenshots
The cursor is at the left of the green bar
Screenshot 2020-04-06 at 14 57 33

Version (please complete the following information):

  • OS: all
  • Browser: all
  • Elastic Charts: master

Additional context
In Kibana the problem doesn't exist.
Seems related to a missing CSS reset used by EUI

Errors in browser console
n/a

Kibana Cross Issues
n/a
@markov00 markov00 added bug Something isn't working :interactions Interactions related issue :styling Styling related issue labels Apr 6, 2020
markov00 added a commit to markov00/elastic-charts that referenced this issue Apr 28, 2020
@markov00
fix(brush): align brush canvas to underlying canvas
d09b783 
fix elastic#620
markov00 pushed a commit that referenced this issue Apr 28, 2020
@semantic-release-bot
chore(release): 19.0.0 [skip ci]
7d8a9d8 
# [19.0.0](v18.4.2...v19.0.0) (2020-04-28)

### Bug Fixes

* tooltip container scroll issue ([#647](#647)) ([f411771](f411771))
* **annotations:** fix alignment at the edges ([#641](#641)) ([43c5a59](43c5a59)), closes [#586](#586)

### Features

* shift click legend items & partition legend hover ([#648](#648)) ([ed91744](ed91744))
* **brush:** add multi axis brushing ([#625](#625)) ([9e49534](9e49534)), closes [#587](#587) [#620](#620)

### BREAKING CHANGES

* **brush:** The type used by the `BrushEndListener` is now in the following form `{ x?: [number, number]; y?: Array<{ groupId: GroupId; values: [number,
number]; }> }` where `x` contains an array of `[min, max]` values, and the  `y` property is an optional array of objects, containing the `GroupId` and the values of the brush for that specific axis.
* **annotations:** In the rectangular annotation, the y0 parameter of the coordinates now refers to the minimum value and the y1 value refers to the maximum value of the y domain.
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 28, 2020
@markov00 markov00 mentioned this issue Apr 29, 2020
Merged
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 19.0.0 [skip ci]
2630057 
# [19.0.0](elastic/elastic-charts@v18.4.2...v19.0.0) (2020-04-28)

### Bug Fixes

* tooltip container scroll issue ([opensearch-project#647](elastic/elastic-charts#647)) ([f0af34b](elastic/elastic-charts@f0af34b))
* **annotations:** fix alignment at the edges ([opensearch-project#641](elastic/elastic-charts#641)) ([c698d08](elastic/elastic-charts@c698d08)), closes [opensearch-project#586](elastic/elastic-charts#586)

### Features

* shift click legend items & partition legend hover ([opensearch-project#648](elastic/elastic-charts#648)) ([cf15ca1](elastic/elastic-charts@cf15ca1))
* **brush:** add multi axis brushing ([opensearch-project#625](elastic/elastic-charts#625)) ([382cb14](elastic/elastic-charts@382cb14)), closes [opensearch-project#587](elastic/elastic-charts#587) [opensearch-project#620](elastic/elastic-charts#620)

### BREAKING CHANGES

* **brush:** The type used by the `BrushEndListener` is now in the following form `{ x?: [number, number]; y?: Array<{ groupId: GroupId; values: [number,
number]; }> }` where `x` contains an array of `[min, max]` values, and the  `y` property is an optional array of objects, containing the `GroupId` and the values of the brush for that specific axis.
* **annotations:** In the rectangular annotation, the y0 parameter of the coordinates now refers to the minimum value and the y1 value refers to the maximum value of the y domain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working :interactions Interactions related issue released Issue released publicly :styling Styling related issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markov00