Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] tutorial shows incorrect URLs and platforms #647

Closed
stockholmux opened this issue Jul 14, 2021 · 4 comments · Fixed by #675
Closed

[BUG] tutorial shows incorrect URLs and platforms #647

stockholmux opened this issue Jul 14, 2021 · 4 comments · Fixed by #675
Labels
bug Something isn't working v1.1.0

Comments

@stockholmux
Copy link
Member

Describe the bug

At /app/home#/tutorial/systemLogs the tutorial shows links to non-existent, webpages, tools, and platforms.

Examples:
https://www.opensearch.org/guide/en/beats/filebeat/main/filebeat-module-system.html -> 404
https://www.opensearch.org/guide/en/beats/filebeat/main/filebeat-installation-configuration.html -> 404
https://www.opensearch.org/downloads/beats/filebeat -> 404
https://artifacts.opensearch.org/downloads/beats/filebeat/filebeat-1.0.0-darwin-x64.tar.gz -> 404 (and incompatible version)

To Reproduce
Steps to reproduce the behavior:

  1. Go to /app/home#/tutorial/systemLogs
  2. Click on almost any link
  3. Get 404

Expected behavior
This page should not exist.

OpenSearch Version
1.0 GA

Dashboards Version
1.0 GA

Plugins

Full bundle

Screenshots

Screen Shot 2021-07-14 at 7 54 39 AM

Host/Environment (please complete the following information):

  • OS: macOS
  • Browser and version: Chrome 91

Additional context

The links to this (and perhaps similar) tutorials seem to be removed but users can still directly access these via existing documentation or information.

@stockholmux stockholmux added bug Something isn't working untriaged labels Jul 14, 2021
@kavilla
Copy link
Member

kavilla commented Jul 14, 2021

As you called out we removed the ability to navigate within the application to hit the tutorial page, but left the code and routes pretty much intact in case we want to re-use the content once we have replacements.

We basically didn't want people to go to the page but you could directly go to if you know the route or have a bookmark. My proposal is to remove the tutorials from the router, but if somebody goes directly they will still get a 404. So do we think that is okay since it is technically solving a 404 with a 404.

@kavilla kavilla removed the untriaged label Jul 14, 2021
@stockholmux
Copy link
Member Author

@kavilla That makes sense.

@kavilla
Copy link
Member

kavilla commented Jul 14, 2021

@kavilla That makes sense.

Sounds good we can use this issue to remove the tutorials from the router.

@kavilla
Copy link
Member

kavilla commented Jul 19, 2021

This issue will encompasses this issue: #373

@kavilla kavilla added the v1.1.0 label Jul 19, 2021
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jul 27, 2021
We removed the ability to access the tutorials page because we do
not have replacement for the links provided by the tutorials.

However, users could directly navigate to those pages if they typed
into the browser or had a bookmark.

This removes those routes from the router.

Issues resolved:
opensearch-project#647

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla linked a pull request Jul 27, 2021 that will close this issue
5 tasks
kavilla added a commit that referenced this issue Aug 4, 2021
We removed the ability to access the tutorials page because we do
not have replacement for the links provided by the tutorials.

However, users could directly navigate to those pages if they typed
into the browser or had a bookmark.

This removes those routes from the router.

Issues resolved:
#647

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Aug 4, 2021
We removed the ability to access the tutorials page because we do
not have replacement for the links provided by the tutorials.

However, users could directly navigate to those pages if they typed
into the browser or had a bookmark.

This removes those routes from the router.

Issues resolved:
opensearch-project#647

Backport PR:
opensearch-project#675

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this issue Aug 5, 2021
We removed the ability to access the tutorials page because we do
not have replacement for the links provided by the tutorials.

However, users could directly navigate to those pages if they typed
into the browser or had a bookmark.

This removes those routes from the router.

Issues resolved:
#647

Backport PR:
#675

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants